Re: [PATCH 01/48] Bashification of initscripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Sep 7, 2010 at 3:32 PM, Thomas Bächler <thomas@xxxxxxxxxxxxx> wrote:
> Am 30.06.2010 23:47, schrieb Victor Lowther:
>> Despite efforts to make the initscripts POSIX, we use bash 4.0 features.
>>
>> Bashifying this framework should result in about a 30% speedup, assuming no
>> IO latency and that all programs we call also take zero time. :)
>
> I just pushed the patches - I was going to do more review of some of
> them, but I am apparently too busy. Please post any patches (especially
> if a correction of patch 21 is needed, I haven't finished reading the
> discussion) rebased on the current initscripts.git.

Your last patch has a typo (missed close paren):

diff --git a/rc.sysinit b/rc.sysinit
index b25f7ac..dc916a2 100755
--- a/rc.sysinit
+++ b/rc.sysinit
@@ -275,7 +275,7 @@ stat_busy "Removing Leftover Files"
 /bin/rm -f /var/lock/* &>/dev/null
 /bin/rm -rf /tmp/* /tmp/.* &>/dev/null
 /bin/rm -f /forcefsck &>/dev/null
-[[ -d /var/run ]] && /usr/bin/find /var/run/ \! -type d -delete  )
+[[ -d /var/run ]] && /usr/bin/find /var/run/ \! -type d -delete
 : >| /var/run/utmp
 /bin/chmod 0664 /var/run/utmp
 # Keep {x,k,g}dm happy with xorg


[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux