Am 17.07.2010 16:24, schrieb Victor Lowther: >> Sorry for taking so long. Apart from squashing the trivial >> bashifications, all patches I didn't comment on are ACKed. > > That is cool. I went ahead and reworked/squashed everthing I considered > a "trivial bashification" into 6 or 7 patches after taking into account > the feedback from the ML. The result is the bashification-redux branch > @ git://fnordovax.org/~victor/arch-initscripts -- it is now 16 patches > instead of 48, but the end result is exactly the same. I can post it to > the ML if you like. I looked over the new branch and found it much more readable. And although some of the patches are not 100% clean yet (at least one contains a trivial change that wasn't advertised in the commit), I like it. Just a remark about the cryptsetup/crypttab rework (that one is scary, and I didn't read it in details yet): The "last column" of crypttab can contain space, meaning that everything past the fourth column will be treated as one column (the options column). Did you take that into account? I don't think so. I know that crypttab is ugly and scary, and I was planning to replace it with something sane, I just never got around to actually doing it.
Attachment:
signature.asc
Description: OpenPGP digital signature
