On Tue, Oct 27, 2009 at 9:26 PM, Aaron Griffin <aaronmgriffin@xxxxxxxxx>wrote: > On Tue, Oct 27, 2009 at 6:01 AM, Flavio Costa <flavio.cdc@xxxxxxxxx> > wrote: > > On Tue, Oct 27, 2009 at 4:13 AM, Eric Bélanger <snowmaniscool@xxxxxxxxx > >wrote: > > > >> On Tue, Oct 27, 2009 at 1:38 AM, Evangelos Foutras <foutrelis@xxxxxxxxx > > > >> wrote: > >> > Eric Bélanger wrote: > >> >> > >> >> On Mon, Oct 26, 2009 at 10:39 PM, Evangelos Foutras < > >> foutrelis@xxxxxxxxx> > >> >> wrote: > >> >> > >> >>> > >> >>> Hello, > >> >>> > >> >>> The $Id$ keyword came up while talking with Angel and I realized > that > >> the > >> >>> svn:keywords property doesn't get set on PKGBUILD for new packages, > and > >> >>> thus > >> >>> $Id$ doesn't get updated on commit. I believe we should fix this, as > >> this > >> >>> information is useful when determining when a PKGBUILD was last > >> modified > >> >>> and > >> >>> by whom. > >> >>> > >> >>> May I suggest we do the following: > >> >>> > >> >>> 1) Edit the "Adding a package" section [1] of the packaging > >> instructions > >> >>> in > >> >>> the DeveloperWiki to include this step. (Adding `svn propset > >> svn:keywords > >> >>> "Id" new-package/trunk/PKGBUILD' below the $EDITOR line perhaps?) > >> >>> 2) Add this property to all packages (this has been done once before > by > >> >>> Aaron, if I remember correctly). > >> >>> > >> >>> What's your view on this? > >> >>> > >> >>> ---- > >> >>> [1] > >> >>> > >> >>> > >> > http://wiki.archlinux.org/index.php/DeveloperWiki:HOWTO_Be_A_Packager#Adding_a_package > >> >>> > >> >>> > >> >> > >> >> We should do #1. The Id tag should be set when a package is added > to > >> >> the repo. As for option #2, it has already been done. > >> >> > >> > > >> > Unless I'm missing something, it has only been done once, on > 2008-04-18. > >> > Packages added after that point do not have the svn:keywords property > set > >> > (e.g.: aufs2). > >> > >> Yes, that's what I meant. It was done once on the whole repos when it > >> was moved to svn. Devs and TUs who adds packages need to run the svn > >> propset command to set the Id tag. > >> > >> > > >> > (Thanks for amending the developer wiki, by the way.) > >> > > >> > > > > What about SVN autoprops, can't you just attach a "pre-made" > > '~/.subversion/config' in the wiki and people can grab it from there. > > I was going to suggest this too. I don't recall the syntax, though, > but we should be able to match PKGBUILD files and set autoprops for > that. > > It's so lame that svn doesn't let you set properties like this at the > directory level... > Indeed! -- Flávio Coutinho da Costa
