Loui Chang wrote:
On Tue 27 Oct 2009 04:39 +0200, Evangelos Foutras wrote:
Hello,
The $Id$ keyword came up while talking with Angel and I realized that
the svn:keywords property doesn't get set on PKGBUILD for new
packages, and thus $Id$ doesn't get updated on commit. I believe we
should fix this, as this information is useful when determining when
a PKGBUILD was last modified and by whom.
May I suggest we do the following:
1) Edit the "Adding a package" section [1] of the packaging
instructions in the DeveloperWiki to include this step. (Adding `svn
propset svn:keywords "Id" new-package/trunk/PKGBUILD' below the
$EDITOR line perhaps?)
2) Add this property to all packages (this has been done once before
by Aaron, if I remember correctly).
What's your view on this?
I don't see why we need to taint the source files with these ID tags.
Isn't SVN enough to give us information about our revision history?
Files from ABS don't contain any revision history. Besides, it's faster
and easier to obtain this information by glancing at the first line when
you're editing a PKGBUILD, than by doing `svn info PKGBUILD' from the
terminal.
You may have a point regarding the purposefulness (or lack of thereof)
of these tags. However, please note that I'm focusing on the fact that
right now we have several PKGBUILDs with empty $Id$ lines and not
whether these tags should exist at all or not.
