I'm making some progress on this looking at more debug logs. 2.4.62 seems to never hit this fixup UDS function (fixup_uds_filename) in proxy_util.c. I can see the log message in 2.4.37 but not in 2.4.62. So I think the URL is 'fixed up' in previous versions such that the mod_proxy_http can then do it's thing and accepts the URL. In 2.4.62 the URL isn't fixed up (still a unix scheme) so mod_proxy_http declines it. 2.4.37 (works) [Tue Aug 13 19:40:21.417210 2024] [proxy:trace2] [pid 60:tid 137495759730432] proxy_util.c(2130): [client 10.0.2.100:44344] *: fixup UDS from proxy:unix:/var/run/ondemand-nginx/jeff/passenger.sock|http://localhost/pun/sys/dashboard: http://localhost/pun/sys/dashboard (/var/run/ondemand-nginx/jeff/passenger.sock), referer: http://localhost:5556/ [Tue Aug 13 19:40:21.417227 2024] [proxy_http:trace1] [pid 60:tid 137495759730432] mod_proxy_http.c(1764): [client 10.0.2.100:44344] HTTP: serving URL http://localhost/pun/sys/dashboard, referer: http://localhost:5556/ 2.4.62 (doesn't work) [Tue Aug 13 19:21:14.167869 2024] [proxy_http:debug] [pid 474:tid 563] mod_proxy_http.c(1901): [client 10.0.2.100:49356] AH01113: HTTP: declining URL unix:/var/run/ondemand-nginx/jeff/passenger.sock|http://localhost/pun/sys/dashboard, referer: http://localhost:5556/ -----Original Message----- From: Ohrstrom, Jeffrey <johrstrom@xxxxxxx> Sent: Tuesday, August 13, 2024 2:05 PM To: users@xxxxxxxxxxxxxxxx Subject: RE: 2.4.62 broke my UDS reverse proxy Sorry if that link got mangled. It's this URL path on github.com. /OSC/ondemand/blob/eb4494ec7af2e4c0aa7fca7c23337e2402348a7f/mod_ood_proxy/lib/ood/proxy.lua#L11 -----Original Message----- From: Ohrstrom, Jeffrey <johrstrom@xxxxxxx> Sent: Tuesday, August 13, 2024 2:00 PM To: users@xxxxxxxxxxxxxxxx Subject: RE: 2.4.62 broke my UDS reverse proxy Thanks for the response! Here's the lua code - though it's a different bit (pun_proxy.lua is a directory above and calls this method that I think is more relevant). You can see in my original email the -- req_handler="proxy-server" -- is set. https://urldefense.com/v3/__https://github.com/OSC/ondemand/blob/eb4494ec7af2e4c0aa7fca7c23337e2402348a7f/mod_ood_proxy/lib/ood/proxy.lua*L11__;Iw!!KGKeukY!yRUPbAMh_Biv42wlJWtFZjlnuJQW06xctY355Mq0RSdUZHxQgnZ9GFqdlYw2w_vMh0gA1-ehk-6EJ3-TI8s$ I've modified that a bit but get the same result - a 500. Here's the newer log line where you can see that req_filenname and req_handler are the same. [Tue Aug 13 17:55:41.593566 2024] [lua:info] [pid 78:tid 167] [client 10.0.2.100:51700] req_accept_charset="" req_port="8080" req_protocol="HTTP/1.1" req_hostname="localhost" log_id="ZrueHX3oluHVFawelxFWZgAAAIE" req_accept_encoding="gzip, deflate, br, zstd" req_cache_control="" time_proxy="0.927" log_time="2024-08-13T17:55:41.592995.0Z" req_accept="text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/png,image/svg+xml,*/*;q=0.8" req_referer="https://urldefense.com/v3/__http://localhost:5556/__;!!KGKeukY!yRUPbAMh_Biv42wlJWtFZjlnuJQW06xctY355Mq0RSdUZHxQgnZ9GFqdlYw2w_vMh0gA1-ehk-6EuPr_9BY$ " res_content_type="text/html; charset=iso-8859-1" req_origin="" req_handler="proxy:unix:/var/run/ondemand-nginx/jeff/passenger.sock|http://localhost/pun/sys/dashboard"; res_content_disp="" remote_user="jeff@localhost" req_user_agent="Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:129.0) Gecko/20100101 Firefox/129.0" req_filename="proxy:unix:/var/run/ondemand-nginx/jeff/passenger.sock|http://localhost/pun/sys/dashboard"; log_hook="ood" req_server_name="localhost" res_content_encoding="" req_is_websocket="false" time_user_map="0.003" res_location="" res_content_length="527" res_content_location="" local_user="jeff" req_uri="/pun/sys/dashboard" req_method="GET" res_content_language="" req_user_ip="10.0.2.100" allowed_hosts="localhost" req_status="500" req_accept_language="en-us,en;q=0.5" req_is_https="false" req_content_type="", referer: https://urldefense.com/v3/__http://localhost:5556/__;!!KGKeukY!yRUPbAMh_Biv42wlJWtFZjlnuJQW06xctY355Mq0RSdUZHxQgnZ9GFqdlYw2w_vMh0gA1-ehk-6EuPr_9BY$ -----Original Message----- From: Eric Covener <covener@xxxxxxxxx> Sent: Tuesday, August 13, 2024 1:41 PM To: users@xxxxxxxxxxxxxxxx Subject: Re: 2.4.62 broke my UDS reverse proxy On Tue, Aug 13, 2024 at 1:13 PM Ohrstrom, Jeffrey <johrstrom@xxxxxxx> wrote: > we use LuaHookFixups to set some things and I get the sense that could have something to do with it. Can you share pun_proxy.lua? Can you test with pun_proxy.lua only touching r->handler in the way that SetHandler example looks in https://urldefense.com/v3/__https://httpd.apache.org/docs/2.4/mod/mod_proxy_fcgi.html__;!!KGKeukY!2-SBh7IFgfwh_cGAsgiREe_sUPol7p1grtp2bX1UgYmueYvTtndbUkCqP8d4hTLkuvHTlClZOCJ5RUw$ ? I am wondering if the config mechanism in pun_proxy.lua is somehow a hybrid of both and confuses 2.4.62. --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscribe@xxxxxxxxxxxxxxxx For additional commands, e-mail: users-help@xxxxxxxxxxxxxxxx --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscribe@xxxxxxxxxxxxxxxx For additional commands, e-mail: users-help@xxxxxxxxxxxxxxxx --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscribe@xxxxxxxxxxxxxxxx For additional commands, e-mail: users-help@xxxxxxxxxxxxxxxx --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscribe@xxxxxxxxxxxxxxxx For additional commands, e-mail: users-help@xxxxxxxxxxxxxxxx
|