Re: [PATCH] drm/amd/pm: drop unneeded dpm features disablement for SMU 14.0.0

["Zhang, Yifan" <Yifan1.Zhang@xxxxxxx>]

[AMD Official Use Only - General]

This patch is:
Reviewed-by: Yifan Zhang <yifan1.zhang@xxxxxxx>

---

发件人: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> 代表 jiadong.zhu@xxxxxxx <jiadong.zhu@xxxxxxx>
发送时间: Thursday, October 19, 2023 11:38:45 AM
收件人: amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
抄送: Zhu, Jiadong <Jiadong.Zhu@xxxxxxx>
主题: [PATCH] drm/amd/pm: drop unneeded dpm features disablement for SMU 14.0.0

 

From: Jiadong Zhu <Jiadong.Zhu@xxxxxxx>

PMFW will handle the features disablement properly for gpu reset case,
driver involvement may cause some unexpected issues.

Signed-off-by: Jiadong Zhu <Jiadong.Zhu@xxxxxxx>
---
 drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
index 7c3356d6da5e..ace71abbbcf6 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
@@ -1677,13 +1677,14 @@ static int smu_disable_dpms(struct smu_context *smu)
         }
 
         /*
-        * For SMU 13.0.4/11, PMFW will handle the features disablement properly
+        * For SMU 13.0.4/11 and 14.0.0, PMFW will handle the features disablement properly
          * for gpu reset and S0i3 cases. Driver involvement is unnecessary.
          */
         if (amdgpu_in_reset(adev) || adev->in_s0ix) {
                 switch (amdgpu_ip_version(adev, MP1_HWIP, 0)) {
                 case IP_VERSION(13, 0, 4):
                 case IP_VERSION(13, 0, 11):
+               case IP_VERSION(14, 0, 0):
                         return 0;
                 default:
                         break;
--
2.25.1