Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes

To: André Almeida <andrealmeid@xxxxxxxxxx>
Subject: Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes
From: Simon Ser <contact@xxxxxxxxxxx>
Date: Tue, 17 Oct 2023 12:16:20 +0000
Cc: pierre-eric.pelloux-prayer@xxxxxxx, 'Marek Olšák' <maraeo@xxxxxxxxx>, Michel Dänzer <michel.daenzer@xxxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, amd-gfx@xxxxxxxxxxxxxxxxxxxxx, Pekka Paalanen <ppaalanen@xxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, kernel-dev@xxxxxxxxxx, alexander.deucher@xxxxxxx, hwentlan@xxxxxxx, christian.koenig@xxxxxxx, joshua@xxxxxxxxx
Feedback-id: 1358184:user:proton
In-reply-to: <CzEtDALWvF3EU4DDLLEmH3ms0B25PbsEHRU9b_IqwfyhzdG4zC-XXAU6fm2PnMcngAYmntH7s4iuew0vocN6cO8zUit8kgi-Sb1hBQXNYiw=@emersion.fr>
References: <20231017092837.32428-1-andrealmeid@igalia.com> <20231017092837.32428-5-andrealmeid@igalia.com> <CzEtDALWvF3EU4DDLLEmH3ms0B25PbsEHRU9b_IqwfyhzdG4zC-XXAU6fm2PnMcngAYmntH7s4iuew0vocN6cO8zUit8kgi-Sb1hBQXNYiw=@emersion.fr>

After discussing with André it seems like we missed a plane type check
here. We need to make sure FB_ID changes are only allowed on primary
planes.

Follow-Ups:
- Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes
  - From: Michel Dänzer

References:
- [PATCH v7 0/6] drm: Add support for atomic async page-flip
  - From: André Almeida
- [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes
  - From: André Almeida
- Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes
  - From: Simon Ser