|
[AMD Official Use Only - General]
Hey Chris,
Yes, we use bitfield as flags to control certain features.
From: Christian König <ckoenig.leichtzumerken@xxxxxxxxx>
Sent: Monday, October 16, 2023 1:58 PM To: Zhang, Bokun <Bokun.Zhang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx> Subject: Re: [PATCH v4 1/4] drm/amd/amdgpu/vcn: Add RB decouple feature under SRIOV - P1 Am 16.10.23 um 18:52 schrieb Bokun Zhang:
> - Update SRIOV header with RB decouple flag > > Signed-off-by: Bokun Zhang <bokun.zhang@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h b/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h > index 104a5ad8397d..51a14f6d93bd 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h > @@ -90,10 +90,11 @@ union amd_sriov_msg_feature_flags { > uint32_t host_load_ucodes : 1; > uint32_t host_flr_vramlost : 1; > uint32_t mm_bw_management : 1; > - uint32_t pp_one_vf_mode : 1; > + uint32_t pp_one_vf_mode : 1; > uint32_t reg_indirect_acc : 1; > uint32_t av1_support : 1; > - uint32_t reserved : 25; > + uint32_t vcn_rb_decouple : 1; > + uint32_t reserved : 24; Are you guys using bitfields for SRIOV guest<->host communication? Christian. > } flags; > uint32_t all; > }; |
