Re: [PATCH] drm/amdgpu: Avoid FRU EEPROM access on APU

["Wang, Yang(Kevin)" <KevinYang.Wang@xxxxxxx>]

[AMD Official Use Only - General]

Reviewed-by: Yang Wang <kevinyang.wang@xxxxxxx>

Best Regards

Kevin

---

发件人: Lazar, Lijo <Lijo.Lazar@xxxxxxx>
发送时间: 星期四, 十月 12, 2023 15:36
收件人: amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
抄送: Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Wang, Yang(Kevin) <KevinYang.Wang@xxxxxxx>
主题: [PATCH] drm/amdgpu: Avoid FRU EEPROM access on APU

 

FRU EEPROM access is not valid for APU devices.

Signed-off-by: Lijo Lazar <lijo.lazar@xxxxxxx>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
index d635e61805ea..a08c148b13f9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
@@ -42,8 +42,9 @@ static bool is_fru_eeprom_supported(struct amdgpu_device *adev, u32 *fru_addr)
 
         /* The i2c access is blocked on VF
          * TODO: Need other way to get the info
+        * Also, FRU not valid for APU devices.
          */
-       if (amdgpu_sriov_vf(adev))
+       if (amdgpu_sriov_vf(adev) || (adev->flags & AMD_IS_APU))
                 return false;
 
         /* The default I2C EEPROM address of the FRU.
--
2.25.1