On Fri, Oct 6, 2023 at 9:32 AM Lazar, Lijo <Lijo.Lazar@xxxxxxx> wrote:
>
> [AMD Official Use Only - General]
>
> Presently only a byte stream is intended. If version is needed, uint16_t pad can be converted to format/content revision.
>
> @Deucher, Alexander/@StDenis, Tom, any comments on keeping a version?
What version are you referring to in this case? You already have the
pmfw version and the pmlog version.
Alex
>
> Thanks,
> Lijo
>
> -----Original Message-----
> From: Wang, Yang(Kevin) <KevinYang.Wang@xxxxxxx>
> Sent: Friday, October 6, 2023 5:08 PM
> To: Lazar, Lijo <Lijo.Lazar@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> Subject: RE: [PATCH v2 1/4] drm/amdgpu: add pmlog structure definition
>
> [AMD Official Use Only - General]
>
> Hi Lijo,
>
> I prefer to add a version field in header, which is used for compatible in the future, what is your idea?
> When the user attempts to parse this node, they cannot accurately determine the format of the content.
>
> Best Regards,
> Kevin
>
> -----Original Message-----
> From: Lazar, Lijo <Lijo.Lazar@xxxxxxx>
> Sent: Friday, October 6, 2023 1:22 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Wang, Yang(Kevin) <KevinYang.Wang@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> Subject: [PATCH v2 1/4] drm/amdgpu: add pmlog structure definition
>
> From: Alex Deucher <alexander.deucher@xxxxxxx>
>
> Define the pmlog structures to be exposed via sysfs.
>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> Signed-off-by: Lijo Lazar <lijo.lazar@xxxxxxx>
> ---
> drivers/gpu/drm/amd/include/kgd_pp_interface.h | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/include/kgd_pp_interface.h b/drivers/gpu/drm/amd/include/kgd_pp_interface.h
> index e0bb6d39f0c3..9905228fd89c 100644
> --- a/drivers/gpu/drm/amd/include/kgd_pp_interface.h
> +++ b/drivers/gpu/drm/amd/include/kgd_pp_interface.h
> @@ -980,4 +980,19 @@ struct gpu_metrics_v2_4 {
> uint16_t average_soc_current;
> uint16_t average_gfx_current;
> };
> +
> +struct amdgpu_pmlog_header {
> + uint16_t structure_size;
> + uint16_t pad;
> + uint32_t mp1_ip_discovery_version;
> + uint32_t pmfw_version;
> + uint32_t pmlog_version;
> +};
> +
> +struct amdgpu_pmlog {
> + struct amdgpu_pmlog_header common_header;
> +
> + uint8_t data[];
> +};
> +
> #endif
> --
> 2.25.1
>
>
