On 9/14/23 22:52, Alex Deucher wrote:
> On Mon, Sep 11, 2023 at 10:36 AM Michel Dänzer <michel@xxxxxxxxxxx> wrote:
>>
>> From: Michel Dänzer <mdaenzer@xxxxxxxxxx>
>>
>> It can be NULL e.g. with Raven.
>>
>> Fixes: 927e784c180c ("drm/amd/display: Add symclk enable/disable during stream enable/disable")
>> Signed-off-by: Michel Dänzer <mdaenzer@xxxxxxxxxx>
>
> Looks like this was fixed in:
> https://gitlab.freedesktop.org/agd5f/linux/-/commit/7f7925e258288cfcfa2b0e0631fcd91a39744f94
> but needs to be applied to 6.6. I'll queue it up for 6.6.
Thanks.
FWIW, I notice some minor issues in that commit:
The if (dc->link_srv->dp_is_128b_132b_signal(pipe_ctx)) block in dce110_disable_stream still always calculates dto_params & dp_hpo_inst, but doesn't use them if dccg is NULL. (My assumption here was that dccg cannot be NULL in this block, I might be wrong though)
And some cosmetic issues:
The second line of the dccg->funcs->disable_symclk_se call remains incorrectly indented.
The newly guarded dccg->funcs->update_clocks calls lack curly braces around them.
dcn20_enable_stream is left with
} else {
}
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
