Applied. Thanks!
Alex
On Wed, Sep 6, 2023 at 10:00 PM Quan, Evan <Evan.Quan@xxxxxxx> wrote:
>
> [AMD Official Use Only - General]
>
> Yeah, nice catch. But personally I would prefer to change the check as "if (retry <= 0)".
> Either way, the patch is reviewed-by: Evan Quan <evan.quan@xxxxxxx>
>
> Evan
> > -----Original Message-----
> > From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Sent: Wednesday, September 6, 2023 6:55 PM
> > To: Quan, Evan <Evan.Quan@xxxxxxx>; Wang, Yang(Kevin)
> > <KevinYang.Wang@xxxxxxx>
> > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian
> > <Christian.Koenig@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; David
> > Airlie <airlied@xxxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>; Lazar, Lijo
> > <Lijo.Lazar@xxxxxxx>; Kamal, Asad <Asad.Kamal@xxxxxxx>; Zhang,
> > Hawking <Hawking.Zhang@xxxxxxx>; Limonciello, Mario
> > <Mario.Limonciello@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; kernel-
> > janitors@xxxxxxxxxxxxxxx
> > Subject: [PATCH] drm/amdgpu: fix retry loop test
> >
> > This loop will exit with "retry" set to -1 if it fails but the code
> > checks for if "retry" is zero. Fix this by changing post-op to a
> > pre-op. --retry vs retry--.
> >
> > Fixes: e01eeffc3f86 ("drm/amd/pm: avoid driver getting empty metrics table
> > for the first time")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > ---
> > Obviously this only loop 99 times now instead of a hundred but that's
> > fine, this is an approximation.
> >
> > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> > b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> > index ff58ee14a68f..20163a9b2a66 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> > @@ -336,7 +336,7 @@ static int smu_v13_0_6_setup_driver_pptable(struct
> > smu_context *smu)
> >
> > /* Store one-time values in driver PPTable */
> > if (!pptable->Init) {
> > - while (retry--) {
> > + while (--retry) {
> > ret = smu_v13_0_6_get_metrics_table(smu, NULL,
> > true);
> > if (ret)
> > return ret;
> > --
> > 2.39.2
>
