Hi Jim On 9/6/2023 12:02 PM, Jim Cromie wrote:
By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks.
May I know what 207, 1288 mean here? Is it the number of callers already having \n?
If so, this might be a big confusing as its subjective to the code-base you are referring to. So I will just stop with "Most DRM.debug calls already comport with this".
No functional changes. Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx> --- drivers/gpu/drm/msm/msm_fb.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
The change itself LGTM, hence Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
