[AMD Official Use Only - General] With the following patch in place https://patchwork.freedesktop.org/patch/553433/?series=122640&rev=1 Reviewed-by: Asad Kamal <asad.kamal@xxxxxxx> Thanks & Regards Asad -----Original Message----- From: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@xxxxxxx> Sent: Monday, August 21, 2023 12:06 PM To: Kamal, Asad <Asad.Kamal@xxxxxxx>; SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Chen, Guchun <Guchun.Chen@xxxxxxx> Cc: Pan, Xinhui <Xinhui.Pan@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH] drm/amd/pm: Fixes incorrect type in 'amdgpu_hwmon_show_power_avg() & _input()' On 8/21/2023 11:59 AM, Kamal, Asad wrote: > [AMD Official Use Only - General] > > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of > Srinivasan Shanmugam > Sent: Monday, August 21, 2023 11:36 AM > To: Koenig, Christian <Christian.Koenig@xxxxxxx>; Deucher, Alexander > <Alexander.Deucher@xxxxxxx>; Chen, Guchun <Guchun.Chen@xxxxxxx> > Cc: Pan, Xinhui <Xinhui.Pan@xxxxxxx>; SHANMUGAM, SRINIVASAN > <SRINIVASAN.SHANMUGAM@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: [PATCH] drm/amd/pm: Fixes incorrect type in 'amdgpu_hwmon_show_power_avg() & _input()' > > The val is defined as unsigned int type, if(val<0) is invalid, hence > modified its type to ssize_t > > Fixes the below: > > drivers/gpu/drm/amd/pm/amdgpu_pm.c:2800:5-8: WARNING: Unsigned > expression compared with zero: val < 0 > drivers/gpu/drm/amd/pm/amdgpu_pm.c:2813:5-8: WARNING: Unsigned > expression compared with zero: val < 0 > > Cc: Guchun Chen <guchun.chen@xxxxxxx> > Cc: Christian König <christian.koenig@xxxxxxx> > Cc: Alex Deucher <alexander.deucher@xxxxxxx> > Cc: "Pan, Xinhui" <Xinhui.Pan@xxxxxxx> > Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx> > --- > drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > b/drivers/gpu/drm/amd/pm/amdgpu_pm.c > index f03647fa3df6..cdc28e4da0c9 100644 > --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c > @@ -2794,26 +2794,26 @@ static ssize_t amdgpu_hwmon_show_power_avg(struct device *dev, > struct device_attribute *attr, > char *buf) > { > - unsigned int val; > + ssize_t val; > > val = amdgpu_hwmon_get_power(dev, > AMDGPU_PP_SENSOR_GPU_AVG_POWER); > > [Kamal, Asad] amdgpu_hwmon_get_power -> This is returning unsigned int value, Shall we not change return type for amdgpu_hwmon_get_power? Thanks!, looks like there is already a fix posted here https://patchwork.freedesktop.org/patch/553433/?series=122640&rev=1 for 'amdgpu_hwmon_get_power' > if (val < 0) > return val; > > - return sysfs_emit(buf, "%u\n", val); > + return sysfs_emit(buf, "%zd\n", val); > } > > static ssize_t amdgpu_hwmon_show_power_input(struct device *dev, > struct device_attribute *attr, > char *buf) > { > - unsigned int val; > + ssize_t val; > > val = amdgpu_hwmon_get_power(dev, AMDGPU_PP_SENSOR_GPU_INPUT_POWER); > if (val < 0) > return val; > > - return sysfs_emit(buf, "%u\n", val); > + return sysfs_emit(buf, "%zd\n", val); > } > > static ssize_t amdgpu_hwmon_show_power_cap_min(struct device *dev, > -- > 2.25.1 >
