[AMD Official Use Only - General]
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Asad Kamal
Sent: Friday, August 18, 2023 6:30 PM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Lazar, Lijo <Lijo.Lazar@xxxxxxx>; Kamal, Asad <Asad.Kamal@xxxxxxx>; Ma, Le <Le.Ma@xxxxxxx>; Zhang, Morris <Shiwu.Zhang@xxxxxxx>; Arif, Maisam <Maisam.Arif@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>
Subject: [PATCH] drm/amd/pm: Fix critical temp unit of SMU v13.0.6
Critical Temperature needs to be reported in millidegree Celsius.
Signed-off-by: Asad Kamal <asad.kamal@xxxxxxx>
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index 7d8af9b309b7..32da779dbd27 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -2086,7 +2086,7 @@ static int smu_v13_0_6_get_thermal_temperature_range(struct smu_context *smu,
struct smu_temperature_range *range) {
struct amdgpu_device *adev = smu->adev;
- u32 aid_temp, xcd_temp;
+ u32 aid_temp, xcd_temp, mem_temp;
uint32_t smu_version;
u32 ccd_temp = 0;
int ret;
@@ -2119,9 +2119,11 @@ static int smu_v13_0_6_get_thermal_temperature_range(struct smu_context *smu,
if (ret)
goto failed;
- range->hotspot_crit_max = max3(aid_temp, xcd_temp, ccd_temp);
+ range->hotspot_crit_max = max3(aid_temp, xcd_temp, ccd_temp) *
+ SMU_TEMPERATURE_UNITS_PER_CENTIGRADES;
ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_GetCTFLimit,
- PPSMC_HBM_THM_TYPE, &range->mem_crit_max);
+ PPSMC_HBM_THM_TYPE, &mem_temp);
+ range->mem_crit_max = mem_temp *
+SMU_TEMPERATURE_UNITS_PER_CENTIGRADES;
[kevin]:
You'd better check ret value first.
Best Regards,
Kevin
if (ret)
goto failed;
--
2.34.1
