[Public]
Reviewed-by: Guchun Chen <guchun.chen@xxxxxxx>
Regards,
Guchun
> -----Original Message-----
> From: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@xxxxxxx>
> Sent: Friday, August 18, 2023 2:46 PM
> To: Koenig, Christian <Christian.Koenig@xxxxxxx>; Deucher, Alexander
> <Alexander.Deucher@xxxxxxx>; Chen, Guchun <Guchun.Chen@xxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; SHANMUGAM, SRINIVASAN
> <SRINIVASAN.SHANMUGAM@xxxxxxx>; Pan, Xinhui
> <Xinhui.Pan@xxxxxxx>
> Subject: [PATCH] drm/amdgpu: Fix kcalloc over kzalloc in
> 'gmc_v9_0_init_mem_ranges'
>
> Replace kzalloc(n * sizeof(...), ...) with kcalloc(n, sizeof(...), ...) since kcalloc is
> the preferred API in case of allocating with multiply.
>
> Fixes the below:
>
> WARNING: Prefer kcalloc over kzalloc with multiply
>
> Cc: Guchun Chen <guchun.chen@xxxxxxx>
> Cc: Christian König <christian.koenig@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: "Pan, Xinhui" <Xinhui.Pan@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index f9a5a2c0573e..0673cda547bb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -1972,10 +1972,9 @@ static int gmc_v9_0_init_mem_ranges(struct
> amdgpu_device *adev) {
> bool valid;
>
> - adev->gmc.mem_partitions = kzalloc(
> - MAX_MEM_RANGES * sizeof(struct
> amdgpu_mem_partition_info),
> - GFP_KERNEL);
> -
> + adev->gmc.mem_partitions = kcalloc(MAX_MEM_RANGES,
> + sizeof(struct
> amdgpu_mem_partition_info),
> + GFP_KERNEL);
> if (!adev->gmc.mem_partitions)
> return -ENOMEM;
>
> --
> 2.25.1
