RE: [PATCH] drm/amdgpu: Remove unnecessary ras cap check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[AMD Official Use Only - General]

Reviewed-by: Tao Zhou <tao.zhou1@xxxxxxx>

> -----Original Message-----
> From: Hawking Zhang <Hawking.Zhang@xxxxxxx>
> Sent: Wednesday, August 9, 2023 7:22 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Zhou1, Tao <Tao.Zhou1@xxxxxxx>
> Cc: Zhang, Hawking <Hawking.Zhang@xxxxxxx>
> Subject: [PATCH] drm/amdgpu: Remove unnecessary ras cap check
>
> RAS global isr will only be invoked by hardware interrupt. Don't need to query ras
> capability in isr In addition, amdgpu_ras_interrupt_fatal_error_handler
> ensures the isr won't be called from guest linux side by accident. The RAS cap
> check in isr that introduced to fix sriov crash is not needed any more
>
> Signed-off-by: Hawking Zhang <Hawking.Zhang@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index 00658c2816dc..c58b31121fd7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -2970,10 +2970,6 @@ int amdgpu_ras_fini(struct amdgpu_device *adev)
>
>  void amdgpu_ras_global_ras_isr(struct amdgpu_device *adev)  {
> -     amdgpu_ras_check_supported(adev);
> -     if (!adev->ras_hw_enabled)
> -             return;
> -
>       if (atomic_cmpxchg(&amdgpu_ras_in_intr, 0, 1) == 0) {
>               struct amdgpu_ras *ras = amdgpu_ras_get_context(adev);
>
> --
> 2.17.1





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux