Re: [PATCH] drm/amdkfd: Add missing tba_hi programming on aldebaran

[Felix Kuehling <felix.kuehling@xxxxxxx>]

On 2023-08-09 17:26, Jay Cornwall wrote:
> Previously asymptomatic because high 32 bits were zero.
>
> Fixes: 615222cfed20 ("drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole")
> Signed-off-by: Jay Cornwall <jay.cornwall@xxxxxxx>

Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
> index 8fda16e6fee6..8ce6f5200905 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
> @@ -121,6 +121,7 @@ static int pm_map_process_aldebaran(struct packet_manager *pm,
>   	packet->sh_mem_bases = qpd->sh_mem_bases;
>   	if (qpd->tba_addr) {
>   		packet->sq_shader_tba_lo = lower_32_bits(qpd->tba_addr >> 8);
> +		packet->sq_shader_tba_hi = upper_32_bits(qpd->tba_addr >> 8);
>   		packet->sq_shader_tma_lo = lower_32_bits(qpd->tma_addr >> 8);
>   		packet->sq_shader_tma_hi = upper_32_bits(qpd->tma_addr >> 8);
>   	}