[Public]
> -----Original Message-----
> From: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@xxxxxxx>
> Sent: Monday, August 7, 2023 4:27 PM
> To: Koenig, Christian <Christian.Koenig@xxxxxxx>; Deucher, Alexander
> <Alexander.Deucher@xxxxxxx>; Chen, Guchun <Guchun.Chen@xxxxxxx>;
> Pan, Xinhui <Xinhui.Pan@xxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; SHANMUGAM, SRINIVASAN
> <SRINIVASAN.SHANMUGAM@xxxxxxx>
> Subject: [PATCH] drm/amdgpu: Fix identifier names to function definition
> arguments in atom.h
>
> Fixes the following:
>
> WARNING: function definition argument 'struct card_info *' should also have
> an identifier name
> WARNING: function definition argument 'uint32_t' should also have an
> identifier name
> WARNING: function definition argument 'void *' should also have an
> identifier name
> WARNING: function definition argument 'struct atom_context *' should also
> have an identifier name
> WARNING: function definition argument 'int' should also have an identifier
> name
> WARNING: function definition argument 'uint32_t *' should also have an
> identifier name
> WARNING: Unnecessary space before function pointer name
> ERROR: space prohibited after that '*' (ctx:BxW)
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
>
> Cc: Guchun Chen <guchun.chen@xxxxxxx>
> Cc: Christian König <christian.koenig@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: "Pan, Xinhui" <Xinhui.Pan@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>
Reviewed-by: Guchun Chen <guchun.chen@xxxxxxx>
Regards,
Guchun
> ---
> drivers/gpu/drm/amd/amdgpu/atom.h | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/atom.h
> b/drivers/gpu/drm/amd/amdgpu/atom.h
> index 55bf99d5288d..c11cf18a0f18 100644
> --- a/drivers/gpu/drm/amd/amdgpu/atom.h
> +++ b/drivers/gpu/drm/amd/amdgpu/atom.h
> @@ -117,12 +117,15 @@ struct drm_device;
>
> struct card_info {
> struct drm_device *dev;
> - void (* reg_write)(struct card_info *, uint32_t, uint32_t); /* filled by
> driver */
> - uint32_t (* reg_read)(struct card_info *, uint32_t); /* filled by
> driver */
> - void (* mc_write)(struct card_info *, uint32_t, uint32_t); /* filled by
> driver */
> - uint32_t (* mc_read)(struct card_info *, uint32_t); /* filled by
> driver */
> - void (* pll_write)(struct card_info *, uint32_t, uint32_t); /* filled by
> driver */
> - uint32_t (* pll_read)(struct card_info *, uint32_t); /* filled by
> driver */
> + void (*reg_write)(struct card_info *info,
> + u32 reg, uint32_t val); /* filled by driver */
> + uint32_t (*reg_read)(struct card_info *info, uint32_t reg); /*
> filled by driver */
> + void (*mc_write)(struct card_info *info,
> + u32 reg, uint32_t val); /* filled by driver */
> + uint32_t (*mc_read)(struct card_info *info, uint32_t reg); /*
> filled by driver */
> + void (*pll_write)(struct card_info *info,
> + u32 reg, uint32_t val); /* filled by driver */
> + uint32_t (*pll_read)(struct card_info *info, uint32_t reg); /*
> filled by driver */
> };
>
> struct atom_context {
> @@ -152,10 +155,10 @@ struct atom_context {
>
> extern int amdgpu_atom_debug;
>
> -struct atom_context *amdgpu_atom_parse(struct card_info *, void *); -int
> amdgpu_atom_execute_table(struct atom_context *, int, uint32_t *); -int
> amdgpu_atom_asic_init(struct atom_context *); -void
> amdgpu_atom_destroy(struct atom_context *);
> +struct atom_context *amdgpu_atom_parse(struct card_info *card, void
> +*bios); int amdgpu_atom_execute_table(struct atom_context *ctx, int
> +index, uint32_t *params); int amdgpu_atom_asic_init(struct atom_context
> +*ctx); void amdgpu_atom_destroy(struct atom_context *ctx);
> bool amdgpu_atom_parse_data_header(struct atom_context *ctx, int index,
> uint16_t *size,
> uint8_t *frev, uint8_t *crev, uint16_t *data_start);
> bool amdgpu_atom_parse_cmd_header(struct atom_context *ctx, int index,
> --
> 2.25.1
