Re: [PATCH] drm/radeon: Fix ENOSYS with better fitting error codes in radeon_gem.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>

On Wed, Jul 26, 2023 at 10:17 AM Srinivasan Shanmugam
<srinivasan.shanmugam@xxxxxxx> wrote:
>
> Replace the error code from 'ENOSYS' to 'EOPNOTSUPP' for unimplemented
> radeon_gem_pread_ioctl & radeon_gem_pwrite_ioctl
>
> Fixes the following:
>
> WARNING: ENOSYS means 'invalid syscall nr' and nothing else.
>
> Cc: Christian König <christian.koenig@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>
> ---
>  drivers/gpu/drm/radeon/radeon_gem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c
> index d0119c5f7eb3..358d19242f4b 100644
> --- a/drivers/gpu/drm/radeon/radeon_gem.c
> +++ b/drivers/gpu/drm/radeon/radeon_gem.c
> @@ -316,7 +316,7 @@ int radeon_gem_pread_ioctl(struct drm_device *dev, void *data,
>  {
>         /* TODO: implement */
>         DRM_ERROR("unimplemented %s\n", __func__);
> -       return -ENOSYS;
> +       return -EOPNOTSUPP;
>  }
>
>  int radeon_gem_pwrite_ioctl(struct drm_device *dev, void *data,
> @@ -324,7 +324,7 @@ int radeon_gem_pwrite_ioctl(struct drm_device *dev, void *data,
>  {
>         /* TODO: implement */
>         DRM_ERROR("unimplemented %s\n", __func__);
> -       return -ENOSYS;
> +       return -EOPNOTSUPP;
>  }
>
>  int radeon_gem_create_ioctl(struct drm_device *dev, void *data,
> --
> 2.25.1
>




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux