RE: [PATCH] drm/amdgpu: Fix non-standard format specifiers in 'amdgpu_show_fdinfo'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[Public]

Reviewed-by: Guchun Chen <guchun.chen@xxxxxxx>

> -----Original Message-----
> From: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@xxxxxxx>
> Sent: Wednesday, July 26, 2023 3:29 PM
> To: Koenig, Christian <Christian.Koenig@xxxxxxx>; Deucher, Alexander
> <Alexander.Deucher@xxxxxxx>; Chen, Guchun <Guchun.Chen@xxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; SHANMUGAM, SRINIVASAN
> <SRINIVASAN.SHANMUGAM@xxxxxxx>
> Subject: [PATCH] drm/amdgpu: Fix non-standard format specifiers in
> 'amdgpu_show_fdinfo'
>
> Fixes the following:
>
> WARNING: %Lu is non-standard C, use %llu
> +       seq_printf(m, "drm-client-id:\t%Lu\n",
> + vm->immediate.fence_context);
>
> WARNING: %Ld is non-standard C, use %lld
> +               seq_printf(m, "drm-engine-%s:\t%Ld ns\n",
> + amdgpu_ip_name[hw_ip],
>
> Cc: Guchun Chen <guchun.chen@xxxxxxx>
> Cc: Christian König <christian.koenig@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c
> index c57252f004e8..5b253e3be56b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c
> @@ -90,7 +90,7 @@ void amdgpu_show_fdinfo(struct seq_file *m, struct
> file *f)
>       seq_printf(m, "pasid:\t%u\n", fpriv->vm.pasid);
>       seq_printf(m, "drm-driver:\t%s\n", file->minor->dev->driver->name);
>       seq_printf(m, "drm-pdev:\t%04x:%02x:%02x.%d\n", domain, bus,
> dev, fn);
> -     seq_printf(m, "drm-client-id:\t%Lu\n", vm-
> >immediate.fence_context);
> +     seq_printf(m, "drm-client-id:\t%llu\n", vm-
> >immediate.fence_context);
>       seq_printf(m, "drm-memory-vram:\t%llu KiB\n", stats.vram/1024UL);
>       seq_printf(m, "drm-memory-gtt: \t%llu KiB\n", stats.gtt/1024UL);
>       seq_printf(m, "drm-memory-cpu: \t%llu KiB\n", stats.cpu/1024UL);
> @@ -111,7 +111,7 @@ void amdgpu_show_fdinfo(struct seq_file *m, struct
> file *f)
>               if (!usage[hw_ip])
>                       continue;
>
> -             seq_printf(m, "drm-engine-%s:\t%Ld ns\n",
> amdgpu_ip_name[hw_ip],
> +             seq_printf(m, "drm-engine-%s:\t%lld ns\n",
> amdgpu_ip_name[hw_ip],
>                          ktime_to_ns(usage[hw_ip]));
>       }
>  }
> --
> 2.25.1





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux