On Tue, Jul 25, 2023 at 5:20 AM Prike Liang <Prike.Liang@xxxxxxx> wrote: > > Now the SDMA firmware support SDMA MGCG properly, > so let's enable it from the driver side. If this is only supported on certain firmware versions, do we need a version check? Alex > > Signed-off-by: Prike Liang <Prike.Liang@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/nv.c | 6 ++++-- > drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 1 + > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c > index 6853b93ac82e..9bf7872e260d 100644 > --- a/drivers/gpu/drm/amd/amdgpu/nv.c > +++ b/drivers/gpu/drm/amd/amdgpu/nv.c > @@ -901,7 +901,8 @@ static int nv_common_early_init(void *handle) > AMD_CG_SUPPORT_ATHUB_LS | > AMD_CG_SUPPORT_IH_CG | > AMD_CG_SUPPORT_VCN_MGCG | > - AMD_CG_SUPPORT_JPEG_MGCG; > + AMD_CG_SUPPORT_JPEG_MGCG | > + AMD_CG_SUPPORT_SDMA_MGCG; > adev->pg_flags = AMD_PG_SUPPORT_GFX_PG | > AMD_PG_SUPPORT_VCN | > AMD_PG_SUPPORT_VCN_DPG | > @@ -962,7 +963,8 @@ static int nv_common_early_init(void *handle) > AMD_CG_SUPPORT_ATHUB_LS | > AMD_CG_SUPPORT_IH_CG | > AMD_CG_SUPPORT_VCN_MGCG | > - AMD_CG_SUPPORT_JPEG_MGCG; > + AMD_CG_SUPPORT_JPEG_MGCG | > + AMD_CG_SUPPORT_SDMA_MGCG; > adev->pg_flags = AMD_PG_SUPPORT_VCN | > AMD_PG_SUPPORT_VCN_DPG | > AMD_PG_SUPPORT_JPEG | > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c > index 809eca54fc61..f8b6a2637d1d 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c > @@ -1653,6 +1653,7 @@ static int sdma_v5_2_set_clockgating_state(void *handle, > case IP_VERSION(5, 2, 5): > case IP_VERSION(5, 2, 6): > case IP_VERSION(5, 2, 3): > + case IP_VERSION(5, 2, 7): > sdma_v5_2_update_medium_grain_clock_gating(adev, > state == AMD_CG_STATE_GATE); > sdma_v5_2_update_medium_grain_light_sleep(adev, > -- > 2.34.1 >