On Sun, Jul 23, 2023 at 2:51 AM Srinivasan Shanmugam
<srinivasan.shanmugam@xxxxxxx> wrote:
>
> For a constant format without additional arguments, use seq_puts()
> instead of seq_printf(). Also, it fixes the following warning.
>
> WARNING: Prefer seq_puts to seq_printf
>
> And other style fixes:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> WARNING: Block comments should align the * on each line
>
> Cc: Christian König <christian.koenig@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> index e0d3e3aa2e31..0cbaf78e8828 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> @@ -62,7 +62,7 @@
> * Returns 0 on success, error on failure.
> */
> int amdgpu_ib_get(struct amdgpu_device *adev, struct amdgpu_vm *vm,
> - unsigned size, enum amdgpu_ib_pool_type pool_type,
> + unsigned int size, enum amdgpu_ib_pool_type pool_type,
> struct amdgpu_ib *ib)
> {
> int r;
> @@ -123,7 +123,7 @@ void amdgpu_ib_free(struct amdgpu_device *adev, struct amdgpu_ib *ib,
> * a CONST_IB), it will be put on the ring prior to the DE IB. Prior
> * to SI there was just a DE IB.
> */
> -int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,
> +int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned int num_ibs,
> struct amdgpu_ib *ibs, struct amdgpu_job *job,
> struct dma_fence **f)
> {
> @@ -131,16 +131,16 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,
> struct amdgpu_ib *ib = &ibs[0];
> struct dma_fence *tmp = NULL;
> bool need_ctx_switch;
> - unsigned patch_offset = ~0;
> + unsigned int patch_offset = ~0;
> struct amdgpu_vm *vm;
> uint64_t fence_ctx;
> uint32_t status = 0, alloc_size;
> - unsigned fence_flags = 0;
> + unsigned int fence_flags = 0;
> bool secure, init_shadow;
> u64 shadow_va, csa_va, gds_va;
> int vmid = AMDGPU_JOB_GET_VMID(job);
>
> - unsigned i;
> + unsigned int i;
> int r = 0;
> bool need_pipe_sync = false;
>
> @@ -282,7 +282,7 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,
> amdgpu_ring_emit_gfx_shadow(ring, 0, 0, 0, false, 0);
>
> if (ring->funcs->init_cond_exec) {
> - unsigned ce_offset = ~0;
> + unsigned int ce_offset = ~0;
>
> ce_offset = amdgpu_ring_init_cond_exec(ring);
> if (ce_offset != ~0 && ring->funcs->patch_cond_exec)
> @@ -386,7 +386,7 @@ int amdgpu_ib_ring_tests(struct amdgpu_device *adev)
> {
> long tmo_gfx, tmo_mm;
> int r, ret = 0;
> - unsigned i;
> + unsigned int i;
>
> tmo_mm = tmo_gfx = AMDGPU_IB_TEST_TIMEOUT;
> if (amdgpu_sriov_vf(adev)) {
> @@ -403,7 +403,7 @@ int amdgpu_ib_ring_tests(struct amdgpu_device *adev)
> /* for CP & SDMA engines since they are scheduled together so
> * need to make the timeout width enough to cover the time
> * cost waiting for it coming back under RUNTIME only
> - */
> + */
> tmo_gfx = 8 * AMDGPU_IB_TEST_TIMEOUT;
> } else if (adev->gmc.xgmi.hive_id) {
> tmo_gfx = AMDGPU_IB_TEST_GFX_XGMI_TIMEOUT;
> @@ -466,13 +466,13 @@ static int amdgpu_debugfs_sa_info_show(struct seq_file *m, void *unused)
> {
> struct amdgpu_device *adev = m->private;
>
> - seq_printf(m, "--------------------- DELAYED --------------------- \n");
> + seq_puts(m, "--------------------- DELAYED ---------------------\n");
> amdgpu_sa_bo_dump_debug_info(&adev->ib_pools[AMDGPU_IB_POOL_DELAYED],
> m);
> - seq_printf(m, "-------------------- IMMEDIATE -------------------- \n");
> + seq_puts(m, "-------------------- IMMEDIATE --------------------\n");
> amdgpu_sa_bo_dump_debug_info(&adev->ib_pools[AMDGPU_IB_POOL_IMMEDIATE],
> m);
> - seq_printf(m, "--------------------- DIRECT ---------------------- \n");
> + seq_puts(m, "--------------------- DIRECT ----------------------\n");
> amdgpu_sa_bo_dump_debug_info(&adev->ib_pools[AMDGPU_IB_POOL_DIRECT], m);
>
> return 0;
> --
> 2.25.1
>
