[Public] It's better to use prefix "drm/amdgpu: ..." in subject. With it fixed, this patch is: Reviewed-by: Guchun Chen <guchun.chen@xxxxxxx> Regards, Guchun > -----Original Message----- > From: Bob Zhou <bob.zhou@xxxxxxx> > Sent: Monday, July 24, 2023 10:55 AM > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Kim, Jonathan <Jonathan.Kim@xxxxxxx> > Cc: Chen, Guchun <Guchun.Chen@xxxxxxx>; Zhou, Bob > <Bob.Zhou@xxxxxxx> > Subject: [PATCH] drm/amd: remove repeat code for mes_add_queue_pkt > > The setting of mes_add_queue_pkt is repeat, so remove it. > > Signed-off-by: Bob Zhou <bob.zhou@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c > b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c > index 8e67e965f7ea..e806331fee42 100644 > --- a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c > @@ -210,10 +210,6 @@ static int mes_v11_0_add_hw_queue(struct > amdgpu_mes *mes, > mes_add_queue_pkt.is_aql_queue = input->is_aql_queue; > mes_add_queue_pkt.gds_size = input->queue_size; > > - /* For KFD, gds_size is re-used for queue size (needed in MES for AQL > queues) */ > - mes_add_queue_pkt.is_aql_queue = input->is_aql_queue; > - mes_add_queue_pkt.gds_size = input->queue_size; > - > mes_add_queue_pkt.exclusively_scheduled = input- > >exclusively_scheduled; > > return mes_v11_0_submit_pkt_and_poll_completion(mes, > -- > 2.34.1
