Hi Leo, There are two issues here. This change fixing the Crash while secure playback and we see below error: 2023-07-14T15:51:24.837592Z ERR kernel: [ 129.255823] amdgpu 0000:c2:00.0: amdgpu: secure submissions not supported on ring <vcn_unified_0> 2023-07-14T15:51:24.837601Z ERR kernel: [ 129.255827] [drm:amdgpu_job_run] *ERROR* Error scheduling IBs (-22) 2023-07-14T15:51:24.837603Z INFO kernel: [ 129.255834] [drm] Skip scheduling IBs! The second one : https://patchwork.freedesktop.org/patch/547587/ Fixing the garbage/corruption. With both patches playback working fine. Thanks, Suresh G -----Original Message----- From: Liu, Leo <Leo.Liu@xxxxxxx> Sent: Friday, July 14, 2023 7:08 PM To: Guttula, Suresh <Suresh.Guttula@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH 1/2] drm/amdgpu: allow secure submission on VCN4 ring On 2023-07-14 05:44, sguttula wrote: > This patch will enable secure decode playback on VCN4 > > Signed-off-by: sguttula <Suresh.Guttula@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c > b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c > index e8c02ae10163..d199f87febd1 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c > @@ -1804,6 +1804,7 @@ static int vcn_v4_0_ring_patch_cs_in_place(struct amdgpu_cs_parser *p, > static const struct amdgpu_ring_funcs vcn_v4_0_unified_ring_vm_funcs = { > .type = AMDGPU_RING_TYPE_VCN_ENC, > .align_mask = 0x3f, > + .secure_submission_supported = true, We should set it to true with VCN4_0_4 only for now, and check either this boolean or VCN4_0_4 with your implementation from patch 2 Regards, Leo > .nop = VCN_ENC_CMD_NO_OP, > .get_rptr = vcn_v4_0_unified_ring_get_rptr, > .get_wptr = vcn_v4_0_unified_ring_get_wptr,
