Re: [PATCH] drm/amd/pm: disbale dcefclk device sysnode on GFX v9.4.3 chip

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/5/2023 7:55 AM, Wang, Yang(Kevin) wrote:
[AMD Official Use Only - General]

[AMD Official Use Only - General]

Ping...

-----Original Message-----
From: Wang, Yang(Kevin) <KevinYang.Wang@xxxxxxx>
Sent: Friday, June 30, 2023 7:22 PM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Wang, Yang(Kevin) <KevinYang.Wang@xxxxxxx>
Subject: [PATCH] drm/amd/pm: disbale dcefclk device sysnode on GFX v9.4.3 chip

the dceflck sysnode is not aviable on GFX v9.4.3 chip.

Signed-off-by: Yang Wang <kevinyang.wang@xxxxxxx>
---
  drivers/gpu/drm/amd/pm/amdgpu_pm.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 9ef88a0b1b57..5bf401533103 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -2050,7 +2050,8 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
         } else if (DEVICE_ATTR_IS(pp_dpm_dcefclk)) {
                 if (gc_ver < IP_VERSION(9, 0, 0) ||
                     gc_ver == IP_VERSION(9, 4, 1) ||
-                   gc_ver == IP_VERSION(9, 4, 2))
+                   gc_ver == IP_VERSION(9, 4, 2) ||
+                   gc_ver == IP_VERSION(9, 4, 3))

Isn't it better to replace this whole thing with !amdgpu_device_has_display_hardware()?

Thanks,
Lijo

                         *states = ATTR_STATE_UNSUPPORTED;
         } else if (DEVICE_ATTR_IS(pp_dpm_fclk)) {
                 if (mp1_ver < IP_VERSION(10, 0, 0))
--
2.34.1




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux