Re: [PATCH] drm/amdgpu: Prefer dev_warn over printk

[Christian König <ckoenig.leichtzumerken@xxxxxxxxx>]

Am 04.07.23 um 17:43 schrieb Srinivasan Shanmugam:
> Fix the below warning:
>
> WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
> dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...
>
> Cc: Christian König <christian.koenig@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>

Acked-by: Christian König <christian.koenig@xxxxxxx>

> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 2 +-
>   drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 2 +-
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c  | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> index 13b89f78d07d..77a32d53655d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> @@ -973,7 +973,7 @@ static int gmc_v10_0_sw_init(void *handle)
>   
>   	r = dma_set_mask_and_coherent(adev->dev, DMA_BIT_MASK(44));
>   	if (r) {
> -		printk(KERN_WARNING "amdgpu: No suitable DMA available.\n");
> +		dev_warn(adev->dev, "amdgpu: No suitable DMA available.\n");
>   		return r;
>   	}
>   
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
> index c68ecb7dfa39..73ab3624f8fe 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
> @@ -824,7 +824,7 @@ static int gmc_v11_0_sw_init(void *handle)
>   
>   	r = dma_set_mask_and_coherent(adev->dev, DMA_BIT_MASK(44));
>   	if (r) {
> -		printk(KERN_WARNING "amdgpu: No suitable DMA available.\n");
> +		dev_warn(adev->dev, "amdgpu: No suitable DMA available.\n");
>   		return r;
>   	}
>   
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index ebdbc823fae3..2aeeda276ab7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -2151,7 +2151,7 @@ static int gmc_v9_0_sw_init(void *handle)
>   	dma_addr_bits = adev->ip_versions[GC_HWIP][0] >= IP_VERSION(9, 4, 2) ? 48:44;
>   	r = dma_set_mask_and_coherent(adev->dev, DMA_BIT_MASK(dma_addr_bits));
>   	if (r) {
> -		printk(KERN_WARNING "amdgpu: No suitable DMA available.\n");
> +		dev_warn(adev->dev, "amdgpu: No suitable DMA available.\n");
>   		return r;
>   	}
>   	adev->need_swiotlb = drm_need_swiotlb(dma_addr_bits);