On Fri, Jun 16, 2023 at 1:07 AM <jiadong.zhu@xxxxxxx> wrote: > > From: Jiadong Zhu <Jiadong.Zhu@xxxxxxx> > > Gfx9 is using software rings which would trigger mcbp in some cases. > Thus the parameter amdgpu_mcbp shall be enabled by default. > > Signed-off-by: Jiadong Zhu <Jiadong.Zhu@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > index 65577eca58f1..1b3cfda946f9 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > @@ -4527,6 +4527,7 @@ static int gfx_v9_0_early_init(void *handle) > adev->gfx.xcc_mask = 1; > adev->gfx.num_compute_rings = min(amdgpu_gfx_get_num_kcq(adev), > AMDGPU_MAX_COMPUTE_RINGS); > + amdgpu_mcbp = 1; This will enable it for all chips since it's a global. You'll need to store the state in adev->gfx or something like that and enable it on a per chip basis, or just make it the default everywhere. Alex > gfx_v9_0_set_kiq_pm4_funcs(adev); > gfx_v9_0_set_ring_funcs(adev); > gfx_v9_0_set_irq_funcs(adev); > -- > 2.25.1 >
