Am 2023-06-13 um 22:04 schrieb Jiapeng Chong:
Use memdup_user() rather than duplicating its implementation. This is a
little bit restricted to reduce false positives.
./drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c:2813:13-20: WARNING opportunity for memdup_user.
Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5523
Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
Kernel test robot is reporting a failure with this patch, looks like you
used PTR_ERR incorrectly. Please make sure your patch compiles without
warnings.
I see more opportunities to use memdup_user in kfd_chardev.c,
kfd_events.c, kfd_process_queue_manager.c and kfd_svm.c. Do you want to
fix those, too, while you're at it?
Thanks,
Felix
---
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
index d6b15493fffd..637962d4083c 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
@@ -2810,12 +2810,9 @@ static uint32_t *get_queue_ids(uint32_t num_queues, uint32_t *usr_queue_id_array
if (!usr_queue_id_array)
return NULL;
- queue_ids = kzalloc(array_size, GFP_KERNEL);
- if (!queue_ids)
- return ERR_PTR(-ENOMEM);
-
- if (copy_from_user(queue_ids, usr_queue_id_array, array_size))
- return ERR_PTR(-EFAULT);
+ queue_ids = memdup_user(usr_queue_id_array, array_size);
+ if (IS_ERR(queue_ids))
+ return PTR_ERR(queue_ids);
return queue_ids;
}
