> pqn bound in list_for_each_entry loop will not be null, so there is > no need to check whether pqn is NULL or not. Would it be more appropriate to use the wording “Delete an unnecessary check within a list_for_each_entry() loop” instead of “Fix the bug in list_for_each_entry() loops” in the patch subject? > We could remove this check. I suggest to use the sentence “Thus remove a redundant null pointer check.”. See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4-rc6#n94 Regards, Markus
