[Public]
Reviewed-by: Roman Li <Roman.Li@xxxxxxx>
> -----Original Message-----
> From: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@xxxxxxx>
> Sent: Wednesday, May 31, 2023 1:46 PM
> To: Pillai, Aurabindo <Aurabindo.Pillai@xxxxxxx>; Mahfooz, Hamza
> <Hamza.Mahfooz@xxxxxxx>; Siqueira, Rodrigo
> <Rodrigo.Siqueira@xxxxxxx>; Wentland, Harry
> <Harry.Wentland@xxxxxxx>; Li, Roman <Roman.Li@xxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; SHANMUGAM, SRINIVASAN
> <SRINIVASAN.SHANMUGAM@xxxxxxx>
> Subject: [PATCH v2] drm/amd/display: Drop unused DCN_BASE variable in
> dcn314_resource.c
>
> Fixes the following W=1 kernel build warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_resource.c:12
> 8:29: warning: ‘DCN_BASE’ defined but not used [-Wunused-const-variable=]
> 128 | static const struct IP_BASE DCN_BASE = { { { { 0x00000012,
> 0x000000C0, 0x000034C0, 0x00009000, 0x02403C00, 0, 0, 0 } },
> | ^~~~~~~~
>
> Suggested-by: Roman Li <Roman.Li@xxxxxxx>
> Cc: Hamza Mahfooz <hamza.mahfooz@xxxxxxx>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>
> Cc: Harry Wentland <harry.wentland@xxxxxxx>
> Cc: Aurabindo Pillai <aurabindo.pillai@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>
> ---
>
> v2:
> - Remove even unused IP_BASE_INSTANCE and IP_BASE struct definitions
> altogether (Roman)
>
> .../drm/amd/display/dc/dcn314/dcn314_resource.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> index 3592efcc7fae..837884c4f03a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> @@ -117,23 +117,6 @@
> #define regBIF_BX2_BIOS_SCRATCH_6 0x003e
> #define regBIF_BX2_BIOS_SCRATCH_6_BASE_IDX 1
>
> -struct IP_BASE_INSTANCE {
> - unsigned int segment[MAX_SEGMENT];
> -};
> -
> -struct IP_BASE {
> - struct IP_BASE_INSTANCE instance[MAX_INSTANCE];
> -};
> -
> -static const struct IP_BASE DCN_BASE = { { { { 0x00000012, 0x000000C0,
> 0x000034C0, 0x00009000, 0x02403C00, 0, 0, 0 } },
> - { { 0, 0, 0, 0, 0, 0, 0, 0 } },
> - { { 0, 0, 0, 0, 0, 0, 0, 0 } },
> - { { 0, 0, 0, 0, 0, 0, 0, 0 } },
> - { { 0, 0, 0, 0, 0, 0, 0, 0 } },
> - { { 0, 0, 0, 0, 0, 0, 0, 0 } },
> - { { 0, 0, 0, 0, 0, 0, 0, 0 } } } };
> -
> -
> #define DC_LOGGER_INIT(logger)
>
> enum dcn31_clk_src_array_id {
> --
> 2.25.1
