RE: [PATCH] drm/amdgpu: change reserved vram info print

["Chai, Thomas" <YiPeng.Chai@xxxxxxx>]

[AMD Official Use Only - General]

OK, thanks!

 

 

-----------------

Best Regards,

Thomas

 

From: Christian König <ckoenig.leichtzumerken@xxxxxxxxx>
Sent: Thursday, June 1, 2023 2:25 PM
To: Paneer Selvam, Arunpravin <Arunpravin.PaneerSelvam@xxxxxxx>; Chai, Thomas <YiPeng.Chai@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Zhou1, Tao <Tao.Zhou1@xxxxxxx>; Yang, Stanley <Stanley.Yang@xxxxxxx>; Chai, Thomas <YiPeng.Chai@xxxxxxx>; Li, Candice <Candice.Li@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>
Subject: Re: [PATCH] drm/amdgpu: change reserved vram info print

 

If you haven't already pushed it Reviewed-by: Christian König <christian.koenig@xxxxxxx> as well.

You might want to add a CC: stable... tag so that it gets backported.

Regards,
Christian.

Am 01.06.23 um 08:13 schrieb Arunpravin Paneer Selvam:

Reviewed-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@xxxxxxx>

 

On 5/25/2023 2:20 PM, YiPeng Chai wrote

The link object of mgr->reserved_pages is the blocks

variable in struct amdgpu_vram_reservation, not the

link variable in struct drm_buddy_block.

Signed-off-by: YiPeng Chai <YiPeng.Chai@xxxxxxx>

---

 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 7 ++++---

 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c

index 89d35d194f2c..c7085a747b03 100644

--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c

+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c

@@ -839,7 +839,7 @@ static void amdgpu_vram_mgr_debug(struct ttm_resource_manager *man,

 {

   struct amdgpu_vram_mgr *mgr = to_vram_mgr(man);

   struct drm_buddy *mm = &mgr->mm;

-  struct drm_buddy_block *block;

+  struct amdgpu_vram_reservation *rsv;

   drm_printf(printer, "  vis usage:%llu\n",

              amdgpu_vram_mgr_vis_usage(mgr));

@@ -851,8 +851,9 @@ static void amdgpu_vram_mgr_debug(struct ttm_resource_manager *man,

   drm_buddy_print(mm, printer);

   drm_printf(printer, "reserved:\n");

-  list_for_each_entry(block, &mgr->reserved_pages, link)

-     drm_buddy_block_print(mm, block, printer);

+  list_for_each_entry(rsv, &mgr->reserved_pages, blocks)

+          drm_printf(printer, "%#018llx-%#018llx: %llu\n",

+                  rsv->start, rsv->start + rsv->size, rsv->size);

   mutex_unlock(&mgr->lock);

 }