Re: [PATCH] drm/amd/display: Correct kdoc formatting for DCN32_CRB_SEGMENT_SIZE_KB in dcn32_hubbub.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Reviewed-by: Aurabindo Pillai <aurabindo.pillai@xxxxxxx>

On 5/30/23 23:52, Srinivasan Shanmugam wrote:
> Fixes the following W=1 kernel build warning:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_hubbub.c:45: warning: Cannot understand  * @DCN32_CRB_SEGMENT_SIZE_KB: Maximum Configurable Return Buffer size for
>  on line 45 - I thought it was a doc line
> 
> Cc: Hamza Mahfooz <hamza.mahfooz@xxxxxxx>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>
> Cc: Harry Wentland <harry.wentland@xxxxxxx>
> Cc: Aurabindo Pillai <aurabindo.pillai@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubbub.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubbub.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubbub.c
> index eb08ccc38e79..a18b9c0c5709 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubbub.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubbub.c
> @@ -42,8 +42,8 @@
>  	hubbub2->shifts->field_name, hubbub2->masks->field_name
>  
>  /**
> - * @DCN32_CRB_SEGMENT_SIZE_KB: Maximum Configurable Return Buffer size for
> - * DCN32
> + * DCN32_CRB_SEGMENT_SIZE_KB: Maximum Configurable Return Buffer size for
> + *                            DCN32

I think the length limit was increased to 120 characters, so you could put it in the same line itself. But with or without it fixed, the patch is:

Reviewed-by: Aurabindo Pillai <aurabindo.pillai@xxxxxxx>

>   */
>  #define DCN32_CRB_SEGMENT_SIZE_KB 64
>  



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux