On Mon, May 29, 2023 at 10:10 AM Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx> wrote: > > Fix these warnings by adding 'xcc_id' arguments. > > gcc with W=1 > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:1557: warning: Function parameter or member 'xcc_id' not described in 'gfx_v7_0_select_se_sh' > drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c:38: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_gfx_rlc_enter_safe_mode' > drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c:62: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_gfx_rlc_exit_safe_mode' > > Cc: Christian König <christian.koenig@xxxxxxx> > Cc: Alex Deucher <alexander.deucher@xxxxxxx> > Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx> Acked-by: Alex Deucher <alexander.deucher@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 2 ++ > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c > index d3bed9a3e61f..35e0ae9acadc 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c > @@ -31,6 +31,7 @@ > * amdgpu_gfx_rlc_enter_safe_mode - Set RLC into safe mode > * > * @adev: amdgpu_device pointer > + * @xcc_id: xcc accelerated compute core id > * > * Set RLC enter into safe mode if RLC is enabled and haven't in safe mode. > */ > @@ -55,6 +56,7 @@ void amdgpu_gfx_rlc_enter_safe_mode(struct amdgpu_device *adev, int xcc_id) > * amdgpu_gfx_rlc_exit_safe_mode - Set RLC out of safe mode > * > * @adev: amdgpu_device pointer > + * @xcc_id: xcc accelerated compute core id > * > * Set RLC exit safe mode if RLC is enabled and have entered into safe mode. > */ > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c > index 0f0c12bbe228..7b3f13221c0f 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c > @@ -1548,7 +1548,7 @@ static void gfx_v7_0_tiling_mode_table_init(struct amdgpu_device *adev) > * @sh_num: sh block to address > * @instance: Certain registers are instanced per SE or SH. > * 0xffffffff means broadcast to all SEs or SHs (CIK). > - * > + * @xcc_id: xcc accelerated compute core id > * Select which SE, SH combinations to address. > */ > static void gfx_v7_0_select_se_sh(struct amdgpu_device *adev, > -- > 2.25.1 >
