On 5/24/23 15:27, Hamza Mahfooz wrote: > On 5/24/23 15:22, Alex Deucher wrote: >> On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz <hamza.mahfooz@xxxxxxx> wrote: >>> >>> Currently, there are quite a number of issues that are quite easy for >>> the CI to catch, that slip through the cracks. Among them, there are >>> unused variable and indentation issues. Also, we should consider all >>> warnings to be compile errors, since the community will eventually end >>> up complaining about them. So, enable -Werror, -Wunused and >>> -Wmisleading-indentation for all kernel builds. >>> >>> Cc: Alex Deucher <alexander.deucher@xxxxxxx> >>> Cc: Harry Wentland <harry.wentland@xxxxxxx> >>> Cc: Kenny Ho <kenny.ho@xxxxxxx> >>> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@xxxxxxx> >>> --- >>> v2: fix grammatical error >>> --- >>> drivers/gpu/drm/amd/display/Makefile | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile >>> index 0d610cb376bb..3c44162ebe21 100644 >>> --- a/drivers/gpu/drm/amd/display/Makefile >>> +++ b/drivers/gpu/drm/amd/display/Makefile >>> @@ -26,6 +26,8 @@ >>> >>> AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) >>> >>> +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation >>> + >> >> Care to enable this for the rest of amdgpu as well? Or send out an >> additional patch to do that? Either way: >> Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> > > As far as I can tell, if `CONFIG_DRM_AMD_DC` is set it will run these > checks on at least the base driver code. > It's probable best to put that into amdgpu/Makefile in that case. Harry >> >> Alex >> >>> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ >>> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw >>> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr >>> -- >>> 2.40.1 >>>
