[Public]
Thanks for your prompt patch for this.
Reviewed-by: Guchun Chen <guchun.chen@xxxxxxx>
Regards,
Guchun
> -----Original Message-----
> From: Zhang, Yifan <Yifan1.Zhang@xxxxxxx>
> Sent: Wednesday, May 24, 2023 5:01 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Chen, Guchun
> <Guchun.Chen@xxxxxxx>; lizhenneng@xxxxxxxxxx; Zhang, Yifan
> <Yifan1.Zhang@xxxxxxx>
> Subject: [PATCH] drm/amd/pm: Remove unused static functions
> si_set_temperature_range.
>
> Fix compiling warnings:
> CC [M]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.o
> CC [M]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.o
> drivers/gpu/drm/amd/amdgpu/../pm/legacy-dpm/si_dpm.c:6928:12:
> warning: ‘si_set_temperature_range’ defined but not used [-Wunused-
> function]
> 6928 | static int si_set_temperature_range(struct amdgpu_device *adev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> CC [M]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hwseq.o
> CC [M]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer
> .o
> CC [M]
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.o
>
> Fixes: da449f3fef3b ("drm/amd/pm: resolve reboot exception for si oland")
> Signed-off-by: Yifan Zhang <yifan1.zhang@xxxxxxx>
> ---
> drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c
> b/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c
> index ca9bce895dbe..02e69ccff3ba 100644
> --- a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c
> +++ b/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c
> @@ -6925,23 +6925,6 @@ static int si_dpm_enable(struct amdgpu_device
> *adev)
> return 0;
> }
>
> -static int si_set_temperature_range(struct amdgpu_device *adev) -{
> - int ret;
> -
> - ret = si_thermal_enable_alert(adev, false);
> - if (ret)
> - return ret;
> - ret = si_thermal_set_temperature_range(adev,
> R600_TEMP_RANGE_MIN, R600_TEMP_RANGE_MAX);
> - if (ret)
> - return ret;
> - ret = si_thermal_enable_alert(adev, true);
> - if (ret)
> - return ret;
> -
> - return ret;
> -}
> -
> static void si_dpm_disable(struct amdgpu_device *adev) {
> struct rv7xx_power_info *pi = rv770_get_pi(adev);
> --
> 2.37.3
