Re: [PATCH v4] drm/amd/display: Add logging when DP link training Channel EQ is Successful

[Rodrigo Siqueira Jordao <Rodrigo.Siqueira@xxxxxxx>]

On 4/19/23 06:00, Srinivasan Shanmugam wrote:
> Log when Channel Equalization is successful.
>
> Cc: Aurabindo Pillai <aurabindo.pillai@xxxxxxx>
> Cc: Fangzhi Zuo <Jerry.Zuo@xxxxxxx>
>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>
> ---
>
> v2:
>   - For consistency of the printed messages, either drop or keep  %s for both the
>     lines - it is dropped (Aurabindo)
>   - For 128b/132b, moved the statements after EQ interlane alignment
>     is done.
>
> v3:
>   - retained %s for both the lines, useful for better debugging
>
> v4:
>   - move eq/cds messages after dp_perform_128b_132b_channel_eq_done_sequence
>     dp_perform_128b_132b_cds_done_sequence (Jerry)
>     
>
>   .../dc/link/protocols/link_dp_training_128b_132b.c     | 10 ++++++++--
>   .../dc/link/protocols/link_dp_training_8b_10b.c        |  4 ++++
>   2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_128b_132b.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_128b_132b.c
> index 23d380f09a21..db87cfe37b5c 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_128b_132b.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_128b_132b.c
> @@ -211,11 +211,17 @@ enum link_training_result dp_perform_128b_132b_link_training(
>   
>   	dpcd_set_link_settings(link, lt_settings);
>   
> -	if (result == LINK_TRAINING_SUCCESS)
> +	if (result == LINK_TRAINING_SUCCESS) {
>   		result = dp_perform_128b_132b_channel_eq_done_sequence(link, link_res, lt_settings);
> +		if (result == LINK_TRAINING_SUCCESS)
> +			DC_LOG_HW_LINK_TRAINING("%s: Channel EQ done.\n", __func__);
> +	}
>   
> -	if (result == LINK_TRAINING_SUCCESS)
> +	if (result == LINK_TRAINING_SUCCESS) {
>   		result = dp_perform_128b_132b_cds_done_sequence(link, link_res, lt_settings);
> +		if (result == LINK_TRAINING_SUCCESS)
> +			DC_LOG_HW_LINK_TRAINING("%s: CDS done.\n", __func__);
> +	}
>   
>   	return result;
>   }
> diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c
> index 3889ebb2256b..2b4c15b0b407 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c
> @@ -388,6 +388,8 @@ enum link_training_result dp_perform_8b_10b_link_training(
>   					link_res,
>   					lt_settings,
>   					repeater_id);
> +			if (status == LINK_TRAINING_SUCCESS)
> +				DC_LOG_HW_LINK_TRAINING("%s: Channel EQ done.\n", __func__);
>   
>   			repeater_training_done(link, repeater_id);
>   
> @@ -409,6 +411,8 @@ enum link_training_result dp_perform_8b_10b_link_training(
>   					link_res,
>   					lt_settings,
>   					DPRX);
> +			if (status == LINK_TRAINING_SUCCESS)
> +				DC_LOG_HW_LINK_TRAINING("%s: Channel EQ done.\n", __func__);
>   		}
>   	}
>   

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>

And applied to amd-staging-drm-next.