Re: [PATCH] drm/amdgpu: fix memory leak in mes self test

[Christian König <ckoenig.leichtzumerken@xxxxxxxxx>]

Am 21.04.23 um 09:06 schrieb Jack Xiao:
> The fences associated with mes queue have to be freed
> up during amdgpu_ring_fini.
>
> Signed-off-by: Jack Xiao <Jack.Xiao@xxxxxxx>

Well big NAK to this! The fences are supposed to be freed by the fence 
handling code.

Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> index dc474b809604..4a35cee4cb83 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> @@ -361,6 +361,8 @@ void amdgpu_ring_fini(struct amdgpu_ring *ring)
>   		amdgpu_bo_free_kernel(&ring->ring_obj,
>   				      &ring->gpu_addr,
>   				      (void **)&ring->ring);
> +	} else {
> +		kfree(ring->fence_drv.fences);
>   	}
>   
>   	dma_fence_put(ring->vmid_wait);