Re: [PATCH] drm/amd/amdgpu: Fix style issues in amdgpu_discovery.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 19, 2023 at 9:15 AM Srinivasan Shanmugam
<srinivasan.shanmugam@xxxxxxx> wrote:
>
> Fix following checkpatch errors in amdgpu_discovery.c
>
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
> ERROR: code indent should use tabs where possible
>
> Cc: Christian König <christian.koenig@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: Mario Limonciello <mario.limonciello@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>

Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index 0ecce0b92b82..0ba013275dc1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -311,7 +311,7 @@ static int amdgpu_discovery_init(struct amdgpu_device *adev)
>         if (!amdgpu_discovery_verify_binary_signature(adev->mman.discovery_bin) || amdgpu_discovery == 2) {
>                 /* ignore the discovery binary from vram if discovery=2 in kernel module parameter */
>                 if (amdgpu_discovery == 2)
> -                       dev_info(adev->dev,"force read ip discovery binary from file");
> +                       dev_info(adev->dev, "force read ip discovery binary from file");
>                 else
>                         dev_warn(adev->dev, "get invalid ip discovery binary signature from vram\n");
>
> @@ -323,7 +323,7 @@ static int amdgpu_discovery_init(struct amdgpu_device *adev)
>                         goto out;
>                 }
>                 /* check the ip discovery binary signature */
> -               if(!amdgpu_discovery_verify_binary_signature(adev->mman.discovery_bin)) {
> +               if (!amdgpu_discovery_verify_binary_signature(adev->mman.discovery_bin)) {
>                         dev_warn(adev->dev, "get invalid ip discovery binary signature from file\n");
>                         r = -EINVAL;
>                         goto out;
> @@ -529,8 +529,8 @@ static void amdgpu_discovery_read_harvest_bit_per_ip(struct amdgpu_device *adev,
>                                         break;
>                                 default:
>                                         break;
> -                                }
> -                        }
> +                               }
> +                       }
>  next_ip:
>                         ip_offset += struct_size(ip, base_address, ip->num_base_address);
>                 }
> --
> 2.25.1
>




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux