Re: [PATCH] drm/amd/amdgpu: Fix spaces in array indexing and indentations in amdgpu_kms.c

[Christian König <christian.koenig@xxxxxxx>]

Am 19.04.23 um 11:34 schrieb Srinivasan Shanmugam:
> Fix the following errors reported by checkpatch:
>
> ERROR: space prohibited before open square bracket '['
> +#define TA_FW_NAME(type) [TA_FW_TYPE_PSP_##type] = #type
>
> ERROR: code indent should use tabs where possible
> +        query_fw.fw_type = AMDGPU_INFO_FW_GFX_RLCV;$
>
> Cc: Christian König <christian.koenig@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: Mario Limonciello <mario.limonciello@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>

Reviewed-by: Christian König <christian.koenig@xxxxxxx>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> index 1a2e342af1c0..a5bae7eb993a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> @@ -1458,7 +1458,7 @@ static int amdgpu_debugfs_firmware_info_show(struct seq_file *m, void *unused)
>   	int ret, i;
>   
>   	static const char *ta_fw_name[TA_FW_TYPE_MAX_INDEX] = {
> -#define TA_FW_NAME(type) [TA_FW_TYPE_PSP_##type] = #type
> +#define TA_FW_NAME(type)[TA_FW_TYPE_PSP_##type] = #type
>   		TA_FW_NAME(XGMI),
>   		TA_FW_NAME(RAS),
>   		TA_FW_NAME(HDCP),
> @@ -1557,7 +1557,7 @@ static int amdgpu_debugfs_firmware_info_show(struct seq_file *m, void *unused)
>   		   fw_info.feature, fw_info.ver);
>   
>   	/* RLCV */
> -        query_fw.fw_type = AMDGPU_INFO_FW_GFX_RLCV;
> +	query_fw.fw_type = AMDGPU_INFO_FW_GFX_RLCV;
>   	ret = amdgpu_firmware_info(&fw_info, &query_fw, adev);
>   	if (ret)
>   		return ret;