Re: [PATCH] drm/amd/display: Add logging when DP link training Clock recovery is Successful

[Aurabindo Pillai <aurabindo.pillai@xxxxxxx>]

On 4/13/23 15:57, Srinivasan Shanmugam wrote:
> Log when Clock recovery is successful, as part of
> DP link training process.
>
> Cc: Aurabindo Pillai <aurabindo.pillai@xxxxxxx>
> Cc: Fangzhi Zuo <Jerry.Zuo@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>
> ---
>   .../amd/display/dc/link/protocols/link_dp_training_8b_10b.c   | 4 +++-
>   .../drm/amd/display/dc/link/protocols/link_dp_training_dpia.c | 2 ++
>   2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c
> index 41b38da9feb4..8ac4e879032c 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c
> @@ -225,8 +225,10 @@ enum link_training_result perform_8b_10b_clock_recovery_sequence(
>   				offset);
>   
>   		/* 5. check CR done*/
> -		if (dp_is_cr_done(lane_count, dpcd_lane_status))
> +		if (dp_is_cr_done(lane_count, dpcd_lane_status)) {
> +			DC_LOG_HW_LINK_TRAINING("%s: Clock recovery OK\n", __func__);
>   			return LINK_TRAINING_SUCCESS;
> +		}
>   
>   		/* 6. max VS reached*/
>   		if ((link_dp_get_encoding_format(&lt_settings->link_settings) ==
> diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_dpia.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_dpia.c
> index ab4aafdb5e5c..4f4e899e5c46 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_dpia.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_dpia.c
> @@ -401,6 +401,7 @@ static enum link_training_result dpia_training_cr_non_transparent(
>   
>   		/* Check if clock recovery successful. */
>   		if (dp_is_cr_done(lane_count, dpcd_lane_status)) {
> +			DC_LOG_HW_LINK_TRAINING("%s: Clock recovery OK\n", __func__);
>   			result = LINK_TRAINING_SUCCESS;
>   			break;
>   		}
> @@ -508,6 +509,7 @@ static enum link_training_result dpia_training_cr_transparent(
>   
>   		/* Check if clock recovery successful. */
>   		if (dp_is_cr_done(lane_count, dpcd_lane_status)) {
> +			DC_LOG_HW_LINK_TRAINING("%s: Clock recovery OK\n", __func__);
>   			result = LINK_TRAINING_SUCCESS;
>   			break;
>   		}

Reviewed-by: Aurabindo Pillai <aurabindo.pillai@xxxxxxx>