[AMD Official Use Only - General]
Reviewed-by: Fangzhi Zuo <Jerry.Zuo@xxxxxxx>
> -----Original Message-----
> From: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@xxxxxxx>
> Sent: Monday, April 10, 2023 1:36 PM
> To: Wentland, Harry <Harry.Wentland@xxxxxxx>; Zuo, Jerry
> <Jerry.Zuo@xxxxxxx>; Li, Sun peng (Leo) <Sunpeng.Li@xxxxxxx>; Deucher,
> Alexander <Alexander.Deucher@xxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: RE: [PATCH v2] drm/amd/display: Add logging for DP link traning
> Test Pattern Seqeunces
>
> [AMD Official Use Only - General]
>
>
>
> -----Original Message-----
> From: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@xxxxxxx>
> Sent: Monday, April 10, 2023 11:02 PM
> To: Wentland, Harry <Harry.Wentland@xxxxxxx>; Zuo, Jerry
> <Jerry.Zuo@xxxxxxx>; Li, Sun peng (Leo) <Sunpeng.Li@xxxxxxx>; Deucher,
> Alexander <Alexander.Deucher@xxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; SHANMUGAM, SRINIVASAN
> <SRINIVASAN.SHANMUGAM@xxxxxxx>
> Subject: [PATCH v2] drm/amd/display: Add logging for DP link traning Test
> Pattern Seqeunces
>
> Add some more logging for DP link traning test pattern seqeunces for better
> debugging.
>
> Cc: Jerry Zuo <jerry.zuo@xxxxxxx>
> Cc: Harry Wentland <harry.wentland@xxxxxxx>
> Cc: Leo Li <sunpeng.li@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>
> ---
> v2:
>
> - it is better to use : instead of \n, following the log format in default section
> (Jerry)
> - seems no need to print dpcd_tr_pattern if it is already mentioned in the
> string (Jerry)
>
> .../drm/amd/display/dc/link/protocols/link_dp_training.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git
> a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c
> b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c
> index 70fc0ddf2d7e..265233979cf8 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c
> @@ -212,27 +212,36 @@ enum dpcd_training_patterns
>
> switch (pattern) {
> case DP_TRAINING_PATTERN_SEQUENCE_1:
> + DC_LOG_HW_LINK_TRAINING("%s: Using DP training pattern
> TPS1\n",
> +__func__);
> dpcd_tr_pattern = DPCD_TRAINING_PATTERN_1;
> break;
> case DP_TRAINING_PATTERN_SEQUENCE_2:
> + DC_LOG_HW_LINK_TRAINING("%s: Using DP training pattern
> TPS2\n",
> +__func__);
> dpcd_tr_pattern = DPCD_TRAINING_PATTERN_2;
> break;
> case DP_TRAINING_PATTERN_SEQUENCE_3:
> + DC_LOG_HW_LINK_TRAINING("%s: Using DP training pattern
> TPS3\n",
> +__func__);
> dpcd_tr_pattern = DPCD_TRAINING_PATTERN_3;
> break;
> case DP_TRAINING_PATTERN_SEQUENCE_4:
> + DC_LOG_HW_LINK_TRAINING("%s: Using DP training pattern
> TPS4\n",
> +__func__);
> dpcd_tr_pattern = DPCD_TRAINING_PATTERN_4;
> break;
> case DP_128b_132b_TPS1:
> + DC_LOG_HW_LINK_TRAINING("%s: Using DP 128b/132b
> training pattern
> +TPS1\n", __func__);
> dpcd_tr_pattern = DPCD_128b_132b_TPS1;
> break;
> case DP_128b_132b_TPS2:
> + DC_LOG_HW_LINK_TRAINING("%s: Using DP 128b/132b
> training pattern
> +TPS2\n", __func__);
> dpcd_tr_pattern = DPCD_128b_132b_TPS2;
> break;
> case DP_128b_132b_TPS2_CDS:
> + DC_LOG_HW_LINK_TRAINING("%s: Using DP 128b/132b
> training pattern TPS2 CDS\n",
> + __func__);
> dpcd_tr_pattern = DPCD_128b_132b_TPS2_CDS;
> break;
> case DP_TRAINING_PATTERN_VIDEOIDLE:
> + DC_LOG_HW_LINK_TRAINING("%s: Using DP training pattern
> videoidle\n",
> +__func__);
> dpcd_tr_pattern = DPCD_TRAINING_PATTERN_VIDEOIDLE;
> break;
> default:
> --
> 2.25.1
