[AMD Official Use Only - General] Thanks a lot Christian, Mario, & Kent, much appreciate for your help, sent v3 for review : https://patchwork.freedesktop.org/patch/531116/ -----Original Message----- From: Koenig, Christian <Christian.Koenig@xxxxxxx> Sent: Wednesday, April 5, 2023 7:47 PM To: Limonciello, Mario <Mario.Limonciello@xxxxxxx>; Russell, Kent <Kent.Russell@xxxxxxx>; SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH v2] drm/amd/amdgpu: Fix trivial style errors Removing the global job_hang_limit variable and replacing the only place where its used with 0 would probably be a good idea also. Christian. Am 05.04.23 um 16:13 schrieb Mario Limonciello: > Also the changelog should be below the cutlist (---). > > On 4/5/23 09:12, Russell, Kent wrote: >> [AMD Official Use Only - General] >> >> Probably worth changing the commit message and headline now that >> you're removing the parameter instead of just fixing the code style. >> >> Kent >> >>> -----Original Message----- >>> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of >>> Srinivasan Shanmugam >>> Sent: Wednesday, April 5, 2023 9:24 AM >>> To: Koenig, Christian <Christian.Koenig@xxxxxxx>; Deucher, Alexander >>> <Alexander.Deucher@xxxxxxx>; Limonciello, Mario >>> <Mario.Limonciello@xxxxxxx> >>> Cc: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@xxxxxxx>; amd- >>> gfx@xxxxxxxxxxxxxxxxxxxxx >>> Subject: [PATCH v2] drm/amd/amdgpu: Fix trivial style errors >>> >>> Fix coding style errors reported by checkpatch, specifically: >>> >>> ERROR: space prohibited before that ',' (ctx:WxV) >>> +module_param_named(job_hang_limit, amdgpu_job_hang_limit, int >>> +,0444); >>> ^ >>> >>> ERROR: space required after that ',' (ctx:WxV) >>> +module_param_named(job_hang_limit, amdgpu_job_hang_limit, int >>> +,0444); >>> >>> This patch gets rid of all above type of "ERROR" messages in >>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c. >>> >>> v2: The driver doesn't resubmit jobs on hangs any more, hence drop >>> the hang limit module parameter. (Christian) >>> >>> Suggested-by: Christian König <christian.koenig@xxxxxxx> >>> Cc: Alex Deucher <alexander.deucher@xxxxxxx> >>> Cc: Mario Limonciello <mario.limonciello@xxxxxxx> >>> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx> >>> --- >>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 7 ------- >>> 1 file changed, 7 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >>> index e652ffb2c68e..25606af348b8 100644 >>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >>> @@ -521,13 +521,6 @@ MODULE_PARM_DESC(virtual_display, >>> "Enable virtual display feature (the virtual_display will >>> be set like xxxx:xx:xx.x,x;xxxx:xx:xx.x,x)"); >>> module_param_named(virtual_display, amdgpu_virtual_display, charp, >>> 0444); >>> >>> -/** >>> - * DOC: job_hang_limit (int) >>> - * Set how much time allow a job hang and not drop it. The default >>> is 0. >>> - */ >>> -MODULE_PARM_DESC(job_hang_limit, "how much time allow a job hang >>> and not drop it (default 0)"); -module_param_named(job_hang_limit, >>> amdgpu_job_hang_limit, int ,0444); >>> - >>> /** >>> * DOC: lbpw (int) >>> * Override Load Balancing Per Watt (LBPW) support (1 = enable, 0 >>> = disable). >>> The default is -1 (auto, enabled). >>> -- >>> 2.25.1
