[AMD Official Use Only - General] > -----Original Message----- > From: Kuehling, Felix <Felix.Kuehling@xxxxxxx> > Sent: Tuesday, April 4, 2023 9:59 PM > To: Xiao, Shane <shane.xiao@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; > Koenig, Christian <Christian.Koenig@xxxxxxx> > Cc: Liu, Aaron <Aaron.Liu@xxxxxxx>; Guo, Shikai <Shikai.Guo@xxxxxxx> > Subject: Re: [PATCH 3/3] drm/amdgpu: DROP redundant > drm_prime_sg_to_dma_addr_array > > Am 2023-04-04 um 05:56 schrieb Shane Xiao: > > For DMA-MAP userptr on other GPUs, the dma address array has been > > populated in amdgpu_ttm_backend_bind. > > OK. I think "has been populated" should be "will be populated", because > amdgpu_ttm_backend_bind happens as a callback from the ttm_bo_validate > call below. With that fixed in the patch description, the patch is Yes, I will fix the comment. Best Regards, Shane > > Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx> > > > > > > Remove the redundant call from the driver. > > > > Signed-off-by: Shane Xiao <shane.xiao@xxxxxxx> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > > index bcb0a7b32703..94ee8f638c12 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > > @@ -488,9 +488,6 @@ kfd_mem_dmamap_userptr(struct kgd_mem *mem, > > if (unlikely(ret)) > > goto release_sg; > > > > - drm_prime_sg_to_dma_addr_array(ttm->sg, ttm->dma_address, > > - ttm->num_pages); > > - > > amdgpu_bo_placement_from_domain(bo, > AMDGPU_GEM_DOMAIN_GTT); > > ret = ttm_bo_validate(&bo->tbo, &bo->placement, &ctx); > > if (ret)
