Re: [PATCH 02/13] drm/amdgpu/gfx11: check the CP FW version CP GFX shadow support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 31, 2023 at 2:34 AM Christian König
<christian.koenig@xxxxxxx> wrote:
>
> Am 30.03.23 um 21:17 schrieb Alex Deucher:
> > Only set the supported flag if we have new enough CP FW.
> >
> > XXX: don't commit this until the CP FW versions are finalized!
>
> Maybe commit the rest of this series and just hold back this one?
>
> It should still keep everything working.

Yes, that was my plan.

Alex

>
> Regards,
> Christian.
>
> >
> > Acked-by: Christian König <christian.koenig@xxxxxxx>
> > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> > ---
> >   drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> > index a0d830dc0d01..4a50d0fbcdcf 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> > @@ -469,6 +469,15 @@ static void gfx_v11_0_check_fw_cp_gfx_shadow(struct amdgpu_device *adev)
> >       case IP_VERSION(11, 0, 0):
> >       case IP_VERSION(11, 0, 2):
> >       case IP_VERSION(11, 0, 3):
> > +             /* XXX fix me! */
> > +             if ((adev->gfx.me_fw_version >= 1498) &&
> > +                 (adev->gfx.me_feature_version >= 29) &&
> > +                 (adev->gfx.pfp_fw_version >= 1541) &&
> > +                 (adev->gfx.pfp_feature_version >= 29) &&
> > +                 (adev->gfx.mec_fw_version >= 507) &&
> > +                 (adev->gfx.mec_feature_version >= 29))
> > +                     adev->gfx.cp_gfx_shadow = true;
> > +             break;
> >       default:
> >               adev->gfx.cp_gfx_shadow = false;
> >               break;
>




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux