Series is:
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
On Thu, Mar 23, 2023 at 2:06 AM Luben Tuikov <luben.tuikov@xxxxxxx> wrote:
>
> As soon as control->i2c_address is set, return; remove the "break;" from the
> switch--it is unnecessary. This mimics what happens when for some cases in the
> switch, we call helper functions with "return <helper function>".
>
> Remove final function "return true;" to indicate that the switch is final and
> terminal, and that there should be no code after the switch.
>
> Cc: Candice Li <candice.li@xxxxxxx>
> Cc: Kent Russell <kent.russell@xxxxxxx>
> Cc: Alex Deucher <Alexander.Deucher@xxxxxxx>
> Signed-off-by: Luben Tuikov <luben.tuikov@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> index 5c21480fff9c8b..3106fa8a15efef 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> @@ -181,14 +181,14 @@ static bool __get_eeprom_i2c_addr(struct amdgpu_device *adev,
> switch (adev->asic_type) {
> case CHIP_VEGA20:
> control->i2c_address = EEPROM_I2C_MADDR_0;
> - break;
> + return true;
>
> case CHIP_ARCTURUS:
> return __get_eeprom_i2c_addr_arct(adev, control);
>
> case CHIP_SIENNA_CICHLID:
> control->i2c_address = EEPROM_I2C_MADDR_0;
> - break;
> + return true;
>
> case CHIP_ALDEBARAN:
> if (strnstr(atom_ctx->vbios_version, "D673",
> @@ -196,7 +196,7 @@ static bool __get_eeprom_i2c_addr(struct amdgpu_device *adev,
> control->i2c_address = EEPROM_I2C_MADDR_4;
> else
> control->i2c_address = EEPROM_I2C_MADDR_0;
> - break;
> + return true;
>
> case CHIP_IP_DISCOVERY:
> return __get_eeprom_i2c_addr_ip_discovery(adev, control);
> @@ -204,8 +204,6 @@ static bool __get_eeprom_i2c_addr(struct amdgpu_device *adev,
> default:
> return false;
> }
> -
> - return true;
> }
>
> static void
> --
> 2.40.0
>
