On Mon, 20 Mar 2023, Harry Wentland wrote: > > > On 3/20/23 04:19, Lee Jones wrote: > > On Fri, 17 Mar 2023, Alex Deucher wrote: > > > >> On Fri, Mar 17, 2023 at 4:23 AM Lee Jones <lee@xxxxxxxxxx> wrote: > >>> > >>> Fixes the following W=1 kernel build warning(s): > >>> > >>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stat.c:38: warning: Cannot understand ***************************************************************************** > >>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stat.c:76: warning: Cannot understand ***************************************************************************** > >>> > >>> Cc: Harry Wentland <harry.wentland@xxxxxxx> > >>> Cc: Leo Li <sunpeng.li@xxxxxxx> > >>> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx> > >>> Cc: Alex Deucher <alexander.deucher@xxxxxxx> > >>> Cc: "Christian König" <christian.koenig@xxxxxxx> > >>> Cc: "Pan, Xinhui" <Xinhui.Pan@xxxxxxx> > >>> Cc: David Airlie <airlied@xxxxxxxxx> > >>> Cc: Daniel Vetter <daniel@xxxxxxxx> > >>> Cc: Mustapha Ghaddar <mghaddar@xxxxxxx> > >>> Cc: Nicholas Kazlauskas <Nicholas.Kazlauskas@xxxxxxx> > >>> Cc: Jasdeep Dhillon <jdhillon@xxxxxxx> > >>> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > >>> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > >>> Signed-off-by: Lee Jones <lee@xxxxxxxxxx> > >>> --- > >>> drivers/gpu/drm/amd/display/dc/core/dc_stat.c | 28 +++++++------------ > >>> 1 file changed, 10 insertions(+), 18 deletions(-) > >>> > >>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stat.c b/drivers/gpu/drm/amd/display/dc/core/dc_stat.c > >>> index 6c06587dd88c2..5f6392ae31a66 100644 > >>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stat.c > >>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stat.c > >>> @@ -35,19 +35,15 @@ > >>> */ > >>> > >>> /** > >> > >> This looks like it follows some other documentation scheme. Would > >> probably be better to just remove the extra * and make it not kernel > >> doc. @Wentland, Harry @Siqueira, Rodrigo ? > > > > Happy to wait for further input. > > > > Either demoting from or converting to kerneldoc would be fine. > > > > There's no reason they are formatted the way they are. Converting them to > kerneldoc is fine. > > Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx> Thanks for confirming Harry. -- Lee Jones [李琼斯]
