Re: [PATCH] drm/amdgpu: expose more memory stats in fdinfo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Feel free to add my rb on this and push it to amd-staging-drm-next.

Christian.

Am 09.03.23 um 17:02 schrieb Marek Olšák:
Ping

On Thu, Feb 23, 2023 at 1:46 PM Marek Olšák <maraeo@xxxxxxxxx> wrote:
Updated patch attached.

Marek

On Mon, Feb 6, 2023 at 4:05 AM Christian König <ckoenig.leichtzumerken@xxxxxxxxx> wrote:
Just two nit picks:

+    seq_printf(m, "drm-evicted-visible-vram:\t%llu KiB\n",
+           stats.evicted_visible_vram/1024UL);

For the values not standardized for all DRM drivers we might want to use
amd as prefix here instead of drm.

+    uint64_t requested_gtt;        /* how much userspace asked for */

We used to have automated checkers complaining about comments after members.

Kerneldoc complicent comments look like this:

                 /* @timestamp replaced by @rcu on dma_fence_release() */
                 struct rcu_head rcu;

Apart from that looks good to me.

Regards,
Christian.

Am 30.01.23 um 07:56 schrieb Marek Olšák:
> Hi,
>
> This will be used for performance investigations. The patch is attached.
>
> Thanks,
> Marek



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux