Re: [PATCH 2/2] drm/amd/amdkfd: Fix build error with unmatched argument type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 3/8/23 04:34, Qingqing Zhuo wrote:
[Why]
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c: In function ‘svm_migrate_copy_to_vram’:
./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu.h:35:21:
error: format ‘%lx’ expects argument of type ‘long unsigned int’,
but argument 6 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Werror=format=]
    35 | #define pr_fmt(fmt) "amdgpu: " fmt
       |                     ^~~~~~~~~~

[How]
use %llx instead of %lx for ttm_res_offset.

Fixes: d5db9d377c021 ("drm/amdkfd: Fix BO offset for multi-VMA page migration")
Signed-off-by: Qingqing Zhuo <qingqing.zhuo@xxxxxxx>

Cc: Xiaogang Chen <Xiaogang.Chen@xxxxxxx>
Cc: Felix Kuehling <Felix.Kuehling@xxxxxxx>

---

I believe this has already been fixed as of commit 271acc541327
("drm/amdkfd: fix warning in SVM debug statement"), in amd-staging-drm-next.

  drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
index 373cd7b0e1ca..fd54a00e7229 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
@@ -304,7 +304,7 @@ svm_migrate_copy_to_vram(struct amdgpu_device *adev, struct svm_range *prange,
  	uint64_t i, j;
  	int r;
- pr_debug("svms 0x%p [0x%lx 0x%lx 0x%lx]\n", prange->svms, prange->start,
+	pr_debug("svms 0x%p [0x%lx 0x%lx 0x%llx]\n", prange->svms, prange->start,
  		 prange->last, ttm_res_offset);
src = scratch;

--
Hamza




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux