[AMD Official Use Only - General] Thanks. But I think there was already a patch from Kun Liu to address this issue. https://lists.freedesktop.org/archives/amd-gfx/2023-March/090029.html BR Evan > -----Original Message----- > From: Jeff Pang <jeff.pang.chn@xxxxxxxxx> > Sent: Thursday, March 2, 2023 5:16 PM > To: Quan, Evan <Evan.Quan@xxxxxxx> > Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dri- > devel@xxxxxxxxxxxxxxxxxxxxx; Jeff Pang <jeff.pang.chn@xxxxxxxxx> > Subject: [PATCH] gpu: amd/pm: mark symbols static where possible for > smu11 > > I get one warning when building kernel with -Werror=missing-prototypes : > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:1600:5: > error: no previous prototype for ‘vangogh_set_apu_thermal_limit’ > [-Werror=missing-prototypes] > int vangogh_set_apu_thermal_limit(struct smu_context *smu, uint32_t limit) > > In fact, this function don't need a declaration due to it's only used in the file > which they are. > So this patch marks the function with 'static'. > > Signed-off-by: Jeff Pang <jeff.pang.chn@xxxxxxxxx> > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > index 016d5621e0b3..24046af60933 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > @@ -1597,7 +1597,7 @@ static int vangogh_get_apu_thermal_limit(struct > smu_context *smu, uint32_t *limi > 0, limit); > } > > -int vangogh_set_apu_thermal_limit(struct smu_context *smu, uint32_t > limit) > +static int vangogh_set_apu_thermal_limit(struct smu_context *smu, > +uint32_t limit) > { > return smu_cmn_send_smc_msg_with_param(smu, > > SMU_MSG_SetReducedThermalLimit, > -- > 2.34.1
